You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit f3d2619
Browse filesBrowse the repository at this point in the historyBrowse files
perf(ios): confirm fill focus from the tapped input before the keyboard (#3906)
* perf(ios): confirm fill focus from the tapped input before the keyboard
After a focus tap with no keyboard up, stabilization asked for the keyboard
first. While a software keyboard is presented, that query blocks and then
finds none: 0.68 s on an iPhone 17 Pro simulator and 0.57-3.77 s on CI,
before the app-wide focus query confirmed focus anyway and the refresh
point read the input again.
Read the tapped input first and accept its own hasKeyboardFocus, which is
stronger evidence than the keyboard's arrival; that read's frame serves the
refresh point. The keyboard and the app-wide focus query stay as fallbacks.
The runner log names the evidence that confirmed focus.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* perf(ios): carry the focus-confirming read in its evidence
The tapped input's read rides in TextEntryFocusEvidence.inputReportsKeyboardFocus,
so the evidence and the post-focus read cannot disagree. One read per poll
serves both the input's own focus check and the app-wide focus query's
expected snapshot. The keyboard-raising fill test skips before it asserts and
pins the fixture's value-read count at 18 (17 measured, 19 when the entry
resolves the input again). Device timings move from comments to the PR.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* test(ios): name the reads the keyboard-raising fill's pin catches
Removing the focus step's hand-off and dropping the read's seeding both
raise the fixture count from 17 to 19.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
---------
Co-authored-by: Claude Opus 5.5 <[email protected]>
0 commit comments