Skip to content

Commit f1520e3

Browse files
committed
refactor(apple): simplify snapshot route settlement
1 parent 463fd7b commit f1520e3

3 files changed

Lines changed: 109 additions & 138 deletions

File tree

‎packages/platform-apple/src/runner-runtime.ts‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@ export function createAppleRunnerRuntime(options: {
9393
{
9494
source: bridge.source,
9595
resolveTarget: bridge.resolveTarget,
96-
// The runner answers the target read itself; there is no detached discovery to wait on.
97-
isDiscoveryPending: () => false,
98-
targetFreshness: 'cached',
96+
refreshTarget: (device, appBundleId, signal) =>
97+
bridge.resolveTarget(device, appBundleId, signal, 'refresh'),
98+
observeOnlySupported: false,
9999
sessionChanged: bridge.resetTargets,
100100
},
101101
async (device, input) =>
@@ -116,7 +116,6 @@ export function createAppleRunnerRuntime(options: {
116116
): SnapshotRuntimeOperations => {
117117
const route = routeFor(snapshot.present);
118118
const captureSnapshot = async (input: CaptureSnapshotInput) => {
119-
if (input.options?.observeOnly === true) return await snapshot.capture.captureSnapshot(input);
120119
return await route.capture(
121120
options.device,
122121
input,

‎packages/platform-apple/src/runner-snapshot-bridge.test.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,8 @@ function bridgeRoute(provider: AppleRunnerProvider, runnerSessionId?: string) {
162162
{
163163
source: bridge.source,
164164
resolveTarget: bridge.resolveTarget,
165-
isDiscoveryPending: () => false,
166-
targetFreshness: 'cached',
165+
refreshTarget: (device, appBundleId, signal) =>
166+
bridge.resolveTarget(device, appBundleId, signal, 'refresh'),
167167
...(runnerSessionId ? { sessionChanged: bridge.resetTargets } : {}),
168168
},
169169
async () =>
@@ -590,8 +590,8 @@ test('a late presentation failure cannot retire the replacement session generati
590590
{
591591
source: bridge.source,
592592
resolveTarget: bridge.resolveTarget,
593-
isDiscoveryPending: () => false,
594-
targetFreshness: 'cached',
593+
refreshTarget: (device, appBundleId, signal) =>
594+
bridge.resolveTarget(device, appBundleId, signal, 'refresh'),
595595
sessionChanged: bridge.resetTargets,
596596
},
597597
async () => ({ foreground: 'background', sessionId }),
@@ -652,8 +652,8 @@ test('a wedge before the runner id is known does not disable a newly identified
652652
{
653653
source: bridge.source,
654654
resolveTarget: bridge.resolveTarget,
655-
isDiscoveryPending: () => false,
656-
targetFreshness: 'cached',
655+
refreshTarget: (device, appBundleId, signal) =>
656+
bridge.resolveTarget(device, appBundleId, signal, 'refresh'),
657657
sessionChanged: bridge.resetTargets,
658658
},
659659
async () => (sessionId ? { foreground: 'background', sessionId } : { foreground: 'unknown' }),

0 commit comments

Comments
 (0)