Skip to content

Commit f06b188

Browse files
chore: address review feedback on production-exports cleanup (#1276)
- CONTRIBUTING.md: document that intentional non-production exports should use JSDoc @internal with a short justification, treated as a reviewed baseline entry. - isPlatform: fix JSDoc tag to "@internal" and remove conflicting "public" wording. - ARCHIVE_EXTENSIONS: re-export from src/sdk/install-source.ts so the public install-source subpath has a real consumer story for the constant. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 parent a24d302 commit f06b188

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ same-file consumer out of this report without weakening the general Fallow audit
6565
native baseline lives at `fallow-baselines/production-unused-exports.json`.
6666

6767
Fix a finding by wiring the export into production or removing the unnecessary export/code. For
68-
an intentional test seam, explain why beside the declaration and keep the reviewed entry in the
69-
production-export baseline. An inline
68+
an intentional test seam or other non-production consumer, add a JSDoc `@internal` tag with a short
69+
justification beside the declaration and treat it as a reviewed baseline entry. An inline
7070
`// fallow-ignore-next-line unused-export` is not suitable here: the general test-inclusive graph
7171
sees the test consumer and correctly reports that suppression as stale. Run
7272
`pnpm check:production-exports:baseline` only for a deliberate reviewed baseline migration or to

‎src/kernel/device.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ export function resolveDeviceAppleOs(
143143
}
144144

145145
/**
146-
* @internal Public type guard exposed for unit tests.
146+
* @internal Type guard exposed for unit tests.
147147
*/
148148
export function isPlatform(value: unknown): value is Platform {
149149
// Internal device-platform membership derived from the canonical PLATFORMS tuple.

‎src/sdk/install-source.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
export {
2+
ARCHIVE_EXTENSIONS,
23
isTrustedInstallSourceUrl,
34
validateDownloadSourceUrl,
45
} from '../platforms/install-source.ts';

0 commit comments

Comments
 (0)