Repository navigation
Commit ee117c4
authored
fix: scope Android settle diffs to app content and collapse IME chrome (#1200)
* fix: scope Android settle diffs to app content and collapse IME chrome
Android --settle diffs were flooded by system chrome: status-bar churn
(clock/signal/battery) appeared as +/- lines in every settled diff, and
summoning the keyboard added dozens of IME ref-bearing nodes that
suppressed the unchanged-interactive tail (it fired zero times across
the 2026-07-10 Android benchmark, regressing haiku to 2/3 success).
Every Android accessibility node carries its owning package (bundleId),
so settle chrome is now classified per node: IME-owned nodes collapse
to one surviving line per contiguous run (the iOS [Keyboard] analog),
and with a session appBundleId all other foreign-package nodes are
dropped from both diff sides, mirroring record --scope app (#1163).
Classification deliberately never walks parentIndex chains: Android's
interactive-only pruning can chain an app node's parent through another
window's node (locked in by a real-capture regression test). Inert on
iOS/macOS, whose nodes never set bundleId.
Benchmark (haiku, settle arm, 3 runs): 2/3 -> 3/3 success, snapshots
per run 21/5/6 -> 7/1/3, settle uses 3/9/8 -> 10/11/11.
* fix: keep unknown-foreign Android packages in settle output
PR #1200 review blocker (live-reproduced with a real Sharesheet): the
initial blanket foreign-package drop made settle blind to blocking
system dialogs — a ResolverActivity over the app produced an empty diff
and a tail pointing at covered buttons, relocating the death-spiral
failure mode from IME noise to system dialogs.
Invert the default to three per-node tiers: IME packages still collapse
to one line per contiguous run; persistent system chrome (exactly
com.android.systemui, the status-bar churn that motivated the fix)
drops from both diff sides; every other foreign package is kept in
full — a permission prompt's or share sheet's buttons stay actionable.
appBundleId is no longer a classification input, only the
never-drop-the-app-under-test guard, which also defuses the pre-action
staleness noted in review.
Regression tests use the real captured Sharesheet (raw 41-node +
interactive 10-node shapes, package "android" throughout).
* fix: drop only status/nav-bar systemui runs from settle output
Second review round on PR #1200: com.android.systemui hosts actionable
overlays (volume panel, media/output pickers, some system prompts), so
package-level dropping reintroduced dialog blindness for that class.
Key the drop on window-runs instead, live-verified on the emulator: the
status-bar window carries com.android.systemui:id/status_bar* markers
throughout while the VolumeDialog window carries only volume_dialog*
ids. A systemui run (contiguous same-package parent chain) drops only
when a member matches the status_bar*/navigation_bar* marker prefixes;
every other systemui surface is kept with actionable refs. Run grouping
never crosses packages, preserving the per-node cross-window guarantee.
Also corrects the tracking-issue references (#1178 was an unrelated
registry issue; the Android settle-noise issue is #1198) and adds a
real-capture VolumeDialog regression test: status bar drops, volume
dialog survives in both diff and tail.1 parent d968a27 commit ee117c4
2 files changed
Lines changed: 1355 additions & 25 deletions
0 commit comments