Skip to content

Commit ea85fd3

Browse files
thymikeeclaude
andcommitted
chore(gates): describe the runner's test membership without the moved inline test
RunnerTapPointPolicy.swift no longer declares a test, so the declaration scan and its test stop citing it as the file whose name hid one. Part of #2792 Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent 6511c93 commit ea85fd3

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

‎scripts/__tests__/xctest-declarations.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ describe('the declaration scan', () => {
5555
});
5656

5757
test('reads a file whose name does not start with RunnerTests', () => {
58-
// RunnerTapPointPolicy.swift is the real instance: the synchronized-root-group project
59-
// compiles every .swift in the directory, so file naming carries no membership meaning.
58+
// The synchronized-root-group project compiles every .swift in the directory, so file
59+
// naming carries no membership meaning.
6060
expect(
6161
parseDeclaredTests(TARGET, [
6262
{

‎scripts/__tests__/xctest-selection.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ describe('the real tree', () => {
113113
// own regex, because the Xcode project uses a PBXFileSystemSynchronizedRootGroup — every
114114
// .swift file in it is a member. Reusing the check's own file filter would make this
115115
// tautological, and a name-based filter is exactly the bug it caught
116-
// (RunnerTapPointPolicy.swift declares a test and does not start with "RunnerTests").
116+
// (RunnerTapPointPolicy.swift declared a test and does not start with "RunnerTests").
117117
const directory = path.join(repoRoot, RUNNER_TESTS_DIR);
118118
const countAddressableMethods = (sourceDirectory: string): number =>
119119
fs.readdirSync(sourceDirectory, { withFileTypes: true }).reduce((total, entry) => {

‎scripts/xctest-declarations.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@ import { activeSource, PLATFORMS, type Platform } from './swift-conditional-comp
1414
export const RUNNER_TESTS_DIR = 'apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests';
1515

1616
// Every .swift file below the target directory is a member: the Xcode project uses a
17-
// PBXFileSystemSynchronizedRootGroup, so membership is the directory, not a file list. A
18-
// `RunnerTests*` name filter would miss RunnerTapPointPolicy.swift, which declares a real
19-
// addressable test inside `extension RunnerTests`.
17+
// PBXFileSystemSynchronizedRootGroup, so membership is the directory, not a file list, and a
18+
// file's name says nothing about whether it declares addressable tests.
2019
const SWIFT_SOURCE = /\.swift$/;
2120

2221
// One ordered pass over the source. A column-0 type declaration moves the enclosing type;

0 commit comments

Comments
 (0)