Skip to content

Commit ea5f5f2

Browse files
committed
perf(capture-kit): load the JPEG decoder in the PNG worker only for a transcode job
The daemon prewarms the PNG worker at startup, and its static import of png-transcode evaluated jpeg-js in every daemon's worker thread whether or not a Limrun screenshot was ever taken. The jpeg-to-png case now imports the transcoder on first use.
1 parent ef2f422 commit ea5f5f2

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

‎packages/capture-kit/src/png-worker.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { cropPngBytes } from './png-crop-bytes.ts';
44
import { decodePng, PNG } from './png.ts';
55
import { computeScreenshotDiffPixels } from './screenshot-diff-pixels.ts';
66
import { computePngRgbDifference } from './png-rgb-difference.ts';
7-
import { transcodeScreenshotToPng } from './png-transcode.ts';
87
import {
98
toBuffer,
109
type PngWorkerJobResult,
@@ -18,7 +17,8 @@ import {
1817
* `png-worker-client.ts`; published as the `internal/png-worker` build entry.
1918
*/
2019

21-
function runJob(request: PngWorkerRequest): PngWorkerJobResult {
20+
// The daemon prewarms this worker at startup, so the JPEG decoder loads only for a transcode job.
21+
async function runJob(request: PngWorkerRequest): Promise<PngWorkerJobResult> {
2222
switch (request.kind) {
2323
case 'decode': {
2424
const png = decodePng(toBuffer(request.png), request.label);
@@ -44,6 +44,7 @@ function runJob(request: PngWorkerRequest): PngWorkerJobResult {
4444
return { kind: 'diff-pixels', ...computeScreenshotDiffPixels(request) };
4545
}
4646
case 'jpeg-to-png': {
47+
const { transcodeScreenshotToPng } = await import('./png-transcode.ts');
4748
return {
4849
kind: 'jpeg-to-png',
4950
png: transcodeScreenshotToPng(toBuffer(request.image), request.label),
@@ -95,10 +96,10 @@ function resultBufferViews(result: PngWorkerJobResult): Uint8Array[] {
9596

9697
const port = parentPort;
9798
if (port) {
98-
port.on('message', (request: PngWorkerRequest) => {
99+
port.on('message', async (request: PngWorkerRequest) => {
99100
let response: PngWorkerResponse;
100101
try {
101-
response = { id: request.id, ok: true, result: runJob(request) };
102+
response = { id: request.id, ok: true, result: await runJob(request) };
102103
} catch (error) {
103104
response = { id: request.id, ok: false, error: normalizeError(error) };
104105
}

0 commit comments

Comments
 (0)