Repository navigation
Commit e8fcd97
committed
test(ios-runner): make the presented-surface override answer every registered host
The override for `systemSurfaceHostState` only forced the hosts a test named, so
every other registered host still answered from live simulator state: a registry
walk could not be pinned end to end, and a new registry entry made the test's
answer depend on the machine again. The override is now total while set —
members report foreground, non-members do not. Production is unaffected: the
seam is compiled only under the unit-test flag.
This is hardening, not a mutation-proofed fix. Mutating the override back to the
member-only form stays green on a simulator, because the two registered hosts
already report notRunning there — which is the very reason the seam exists.
Also write down what the `.noApp` presented arm actually controls. Tracing the
first parent of c7b79ee: no `.noApp` command read the prepared target or the
disclosed surface even pre-split (`status`/`uptime`/`recordStop`/`terminate`/
`targetReset`/`shutdown` answer before reading a target, iOS `screenshot`
re-resolves its capture display (#2728), macOS `screenshot` resolves the named
app, and `snapshot` — the only provenance consumer — is `.existingApp` and keeps
its route in `prepareActivatedTarget`). The arm restores the prepared subject and
disclosure, which is what the merge-base chain gave these commands; the test says
so instead of claiming a payload the runner never stamped.1 parent 5709698 commit e8fcd97
4 files changed
Lines changed: 57 additions & 25 deletions
File tree
- apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests
- UnitTests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
464 | 464 | | |
465 | 465 | | |
466 | 466 | | |
467 | | - | |
468 | | - | |
469 | | - | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
470 | 479 | | |
471 | 480 | | |
472 | 481 | | |
| |||
598 | 607 | | |
599 | 608 | | |
600 | 609 | | |
601 | | - | |
602 | | - | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
603 | 614 | | |
604 | 615 | | |
605 | | - | |
606 | | - | |
| 616 | + | |
| 617 | + | |
607 | 618 | | |
608 | 619 | | |
609 | 620 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | | - | |
214 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
215 | 216 | | |
216 | 217 | | |
217 | 218 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
152 | 156 | | |
153 | 157 | | |
154 | 158 | | |
| |||
171 | 175 | | |
172 | 176 | | |
173 | 177 | | |
174 | | - | |
| 178 | + | |
175 | 179 | | |
176 | 180 | | |
177 | 181 | | |
178 | | - | |
| 182 | + | |
179 | 183 | | |
180 | 184 | | |
181 | 185 | | |
| |||
189 | 193 | | |
190 | 194 | | |
191 | 195 | | |
192 | | - | |
| 196 | + | |
| 197 | + | |
193 | 198 | | |
194 | 199 | | |
195 | 200 | | |
| |||
201 | 206 | | |
202 | 207 | | |
203 | 208 | | |
204 | | - | |
205 | | - | |
206 | | - | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
207 | 225 | | |
208 | 226 | | |
209 | 227 | | |
| |||
0 commit comments