Skip to content

Commit e73e7c3

Browse files
committed
docs(adr): correct ADR 0012 owner docs from cross-provider review
List all eight resolutionDisclosure matrix cells, including target-drag and find-focus-dispatch, with the real maestro-direct-selector id. Write the overflow artifact only when the level-capped report still exceeds its byte ceiling. State that client keep-alive already uses sessionActive.
1 parent 6741749 commit e73e7c3

4 files changed

Lines changed: 11 additions & 7 deletions

File tree

‎docs/adr/0012-interactive-replay.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ The direct-iOS fast path has no daemon tree, so it must never invent a unique-ma
4646
Coordinate dispatches and executed Maestro coordinate fallbacks carry no `resolution`.
4747
The executed dispatch, not permission to fall back, determines that cell.
4848
ADR 0011's `resolutionDisclosure` guarantee row enforces this decision.
49-
The [resolution disclosure contract](../../packages/command-runtime/docs/resolution-disclosure.md) owns the shapes and the six matrix cells.
49+
The [resolution disclosure contract](../../packages/command-runtime/docs/resolution-disclosure.md) owns the shapes and the matrix cells.
5050

5151
### 3. Versioned `.ad` target-binding evidence
5252

‎packages/ad-replay/docs/divergence-and-resume.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ The report marks every truncation, redaction, and omission.
8585

8686
## Overflow
8787

88-
If bounded output omits material, the daemon writes the same redacted, per-field-bounded detail to a session-scoped divergence artifact.
88+
Level caps apply first. Only when the level-capped serialized report still exceeds its byte ceiling does the daemon write the same redacted, per-field-bounded detail to a session-scoped divergence artifact. Material that level caps omit while the report fits creates no artifact.
8989
It returns the path and `overflow: { omittedBytes, artifactPath }`.
9090
If the write fails, it returns `artifactUnavailable: true` and preserves the original error.
9191
The artifact contains no raw snapshot tree or unredacted input.

‎packages/command-runtime/docs/resolution-disclosure.md‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,20 +52,22 @@ For non-Maestro dispatches, they delegate to the runtime structural rule.
5252

5353
## Matrix cells
5454

55-
ADR 0011's matrix has a `resolutionDisclosure` guarantee with six accurate cells:
55+
ADR 0011's matrix has a `resolutionDisclosure` guarantee for every interaction path, with five enforced and three inapplicable cells:
5656

5757
- `runtime-selector` enforces the complete pre-action diagnostic shape.
5858
- `runtime-ref` enforces `exact` or `label-fallback` for trailing-label recovery.
59+
- `target-drag` enforces a disclosure for each endpoint: the source and the destination each carry their own `resolution`.
5960
- `native-ref` enforces `exact`.
60-
- `direct-ios-selector` enforces only `{ source: "direct-ios", kind: "not-observed" }`.
61+
- `maestro-direct-selector` enforces only `{ source: "direct-ios", kind: "not-observed" }`.
6162
- `coordinate` is inapplicable because no element resolves.
63+
- `find-focus-dispatch` is inapplicable because it issues no identity (ADR 0014).
6264
- `maestro-non-hittable-fallback` is inapplicable because Maestro owns matching and the fallback executes coordinates.
6365

6466
The **executed dispatch** determines maestro-cell membership.
6567
Permission to use a fallback does not determine membership.
6668
A press that was allowed to fall back but hit its element normally is the direct-iOS path, and it discloses `not-observed`.
6769
Only an executed coordinate fallback belongs to the inapplicable maestro cell.
68-
The four enforced cells use the shared response builder.
70+
The enforced cells use the shared response builder.
6971
The existing direct path delegates `disambiguation` to `runtime-selector` after its raw-match count.
7072
Its `responseIdentity` limitation remains explicit.
7173

@@ -84,13 +86,15 @@ Layer-3 coverage must claim every enforced/delegated cell:
8486
- Runtime-ref `label-fallback` recovery
8587
- Direct-iOS `not-observed` without a snapshot
8688

87-
Matrix and provider contracts cover all six `resolutionDisclosure` cells:
89+
Matrix and provider contracts cover every `resolutionDisclosure` cell:
8890

8991
- Runtime ambiguity/tiebreak and the five-alternative limit
9092
- Runtime/native exact-ref provenance
9193
- Runtime-ref `label-fallback` disclosure
94+
- Target-drag disclosure for the source and destination endpoints
9295
- Direct-iOS `not-observed`
9396
- Coordinate inapplicability
97+
- Find-focus dispatch inapplicability
9498
- Maestro inapplicability on both sides of the permission: fallback taken, and allowed-but-not-taken that discloses `not-observed`
9599
- The retained direct-path waiver list
96100

‎packages/daemon/docs/replay-repair-transaction.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ It must not proceed and later fail `--from` with `SESSION_NOT_FOUND`.
9090

9191
A clean armed replay reaches `COMPLETE` and skips terminal source `close` (issue #1384).
9292
Its session therefore survives.
93-
Once client keep-alive uses `ReplayCommandResult.sessionActive` independently of repair state, it also preserves this daemon.
93+
Client keep-alive uses `ReplayCommandResult.sessionActive` independently of repair state, so it also preserves this daemon while the session remains active.
9494
Publication remains deferred until explicit `close`/`close --save-script` or ordinary idle-reap tears down the session.
9595
This preserves R7's post-repair inspection opportunity.
9696
It changes timing for scripted callers that previously saw the healed sibling immediately after one-shot client exit.

0 commit comments

Comments
 (0)