Skip to content

Commit e689bfd

Browse files
thymikeethymikee
committed
docs(ios): spell the shared-header include for the search-path design
The event bridge's comment still described the removed relative include and dist mirror, and the header's note named paths the consumers no longer use. Say who includes the rule and how the runner finds it. Clear the oxlint prefer-string-replace-all warning in the packaged-source guard.
1 parent d4032ed commit e689bfd

3 files changed

Lines changed: 4 additions & 10 deletions

File tree

‎apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerXCTestEventBridge.m‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
#import "RunnerXCTestEventBridge.h"
22
#import "RunnerObjCExceptionCatcher.h"
33
#import "RunnerAXSnapshotBridge.h"
4-
// The same full-screen rule the Simulator snapshot bridge compiles. This relative path resolves to
5-
// the same file from the checkout (`apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/`) and
6-
// from the packaged source (`dist/apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/`),
7-
// where the packager mirrors the header into `dist/apple/snapshot-bridge/`.
4+
// The shared full-screen rule, from the snapshot bridge; found via HEADER_SEARCH_PATHS.
85
#import "ForegroundApplicationGeometry.h"
96
#import <CoreGraphics/CoreGraphics.h>
107
#import <XCTest/XCTest.h>

‎apple/snapshot-bridge/ForegroundApplicationGeometry.h‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,8 @@
66
// one compilation, not a pinned copy. Each caller keeps its own unknown policy: the bridge keeps
77
// a capture it cannot measure, the runner refuses authorization it cannot prove.
88
//
9-
// Both consumers include this file by bare name, so it must sit on their header search path. The
10-
// Simulator snapshot bridge compiles it from its own directory. The runner's event bridge finds
11-
// it through the UITests target's HEADER_SEARCH_PATHS, whose entries resolve `apple/snapshot-bridge`
12-
// from the runner project in the checkout (`apple/runner/AgentDeviceRunner`) and in an installed
13-
// package (`dist/apple/runner/AgentDeviceRunner`, where the package root carries this directory).
9+
// Both consumers include this file by bare name: the snapshot bridge compiles it from its own
10+
// directory, the runner's UITests target finds it through HEADER_SEARCH_PATHS.
1411

1512
#import <CoreGraphics/CoreGraphics.h>
1613
#import <Foundation/Foundation.h>

‎scripts/check-packaged-runner-swift.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ function sharedHeaderFailures(scratchRoot: string, packagedRoot: string): string
163163
const srcRoot = path.join(packagedRoot, 'AgentDeviceRunner');
164164
const resolvesToHeader = searchPath
165165
.split(',')
166-
.map((entry) => entry.trim().replace(/^"|"$/g, ''))
166+
.map((entry) => entry.trim().replaceAll('"', ''))
167167
.filter((entry) => entry.startsWith('$(SRCROOT)/'))
168168
.some((entry) =>
169169
fs.existsSync(

0 commit comments

Comments
 (0)