Repository navigation
Commit e58e524
committed
fix(ci): classify wrapped commands the same as bare ones (#1429)
`runsProjectCode` read only the first token, so `pnpm exec node scripts/x.ts`
was dropped before the bypass check ran: `pnpm` is not a package script and not
`pnpm gate`, and the `node` that actually executes is the third token. An
unregistered gate could therefore be wired into a qualifying lane by wrapping
it, while `check:gate-manifest` stayed green — contradicting the one invariant
the design rests on.
Reported against 67d535d. Reproduced, and three more spellings with it:
`pnpm --silent exec`, `pnpm --dir X exec`, `pnpm dlx` and `npx` all had the same
effect, and a runner reached without a scripts/ path (`pnpm exec vitest …`,
`node --test <file>`) was never classified as project code at all.
Wrappers are now stripped before classification, by scanning for the `exec`/`dlx`
keyword rather than matching a flag grammar, so `pnpm --dir x exec y` unwraps the
same as `pnpm exec y`. A test runner counts as project code whatever it points at.
The paired regression asserts the property directly: the bare command is one
bypass, and each of five wrapped spellings is also exactly one. Re-running a
suite a registered check already owns stays allowed — that is the separate,
deliberate escape the device lanes use, now pinned by its own test.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01SkS4S8XXrfkJ8TD1VBKkvJ1 parent 67d535d commit e58e524
3 files changed
Lines changed: 85 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
219 | | - | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
220 | 223 | | |
221 | 224 | | |
222 | 225 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
41 | 52 | | |
42 | 53 | | |
43 | 54 | | |
| |||
131 | 142 | | |
132 | 143 | | |
133 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
134 | 189 | | |
135 | 190 | | |
136 | 191 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
58 | 76 | | |
59 | 77 | | |
60 | | - | |
| 78 | + | |
61 | 79 | | |
62 | 80 | | |
63 | 81 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
68 | 87 | | |
69 | | - | |
| 88 | + | |
| 89 | + | |
70 | 90 | | |
71 | 91 | | |
72 | 92 | | |
| |||
0 commit comments