You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e43dd7a
Browse filesBrowse the repository at this point in the historyBrowse files
test(settle): keep a daemon-route dismissal asserting the confirmation, and pin the parity gap
The review on this PR found that padding the provider-scenario dialog past the
arming rule's size bound (SHARED_SCREEN_NODES) silently removed the only test
that checked the 1.5s confirmation through the daemon: the transition stopped
being broad (4 of 6 identities survive), so `waitedMs >= 1_500` had to become
`captures in 2..3`. Revert that padding, which restores the unpadded dialog and
its original assertion; all four provider-scenario cases pass on this rule.
Add the parity case the review asked for: the same presented sheet dismissed
from an interactive baseline (4 nodes, as `snapshot -i` projects it) and from a
full-tree read of the same screen (6 nodes), both asserted to confirm. Measured
on the injected clock, the interactive baseline confirms for 1,502ms and the
full-tree baseline for 27ms with `settled: true` either way — #1831's guard lost
on the route whose baseline happens to be the richer flavour. Marked `fails`, so
the lane stays green and the case turns red ("expected to fail but passed") the
moment #3565's `presentedSurface` replaces the count bound: that red is the
signal to drop the marker, and the assertion is the rewrite's acceptance test.
0 commit comments