You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e41d66e
Browse filesBrowse the repository at this point in the historyBrowse files
fix(recording): sniff the collected copy, keep it until its finalization is journaled, and never serve a refused export
ADR 0024 2.3 records the collected checkpoint only after the copy passes the container sniff. The
simulator copy now gets that sniff (`finalize.sniff`: ftyp + moov, no validator spawn); the export
still gets the full playability verdict once.
The collected copy is removed by a `discard` step the sequence runs after the finalization is
journaled, and again on a replay. Removing it inside `finalize` left a crash window in which the
checkpoint named a copy that no longer existed, so every later stop failed.
When the export copy or the finalizer fails, the caller's paths are removed before the error
returns. A killed simctl used to leave an unplayable file at `--out` next to a failed stop.
Copy file name to clipboardExpand all lines: CHANGELOG.md
+6-4Lines changed: 6 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -72,8 +72,10 @@
72
72
stays `retirable` and the recording stays finishable until the device answers.
73
73
- Changed (record): an iOS Simulator recording no longer has the recorder write the file the caller
74
74
asked for. `simctl` records to a `<name>.native.<ext>` sibling; `record stop` copies that file to a
75
-
`<name>.collected.<ext>` sibling, writes the caller's `--out` path once from the copy, checks that
76
-
export is a playable video, and retires the recorder's own file (ADR 0024 2.3). The
75
+
`<name>.collected.<ext>` sibling, checks that the copy has an MP4 container, writes the caller's
76
+
`--out` path once from the copy, checks that export is a playable video, and retires the recorder's
77
+
own file (ADR 0024 2.3). An export the finalizer refuses is removed, so `--out` only ever holds a
78
+
video that passed that check. The
77
79
caller's path is never a file a recorder is still writing, and a stop that fails before the export
78
80
exists leaves it absent with the copy in place — so the next stop resumes from the copy instead of
79
81
signalling a recorder that already stopped. Both siblings are deleted on success, and a stop that
@@ -84,8 +86,8 @@
84
86
video, so nothing deletes them.
85
87
- Changed (record): an Android recording is no longer pulled onto the path the caller asked for.
86
88
`record stop` pulls the device's chunks to `<name>.collected.<ext>` siblings, retrying each pull
87
-
until it plays, then writes the caller's paths from copies of them and drops the collected set
88
-
(ADR 0024 2.3). A stop that dies before the export exists leaves it absent with the pulled set in
89
+
until it plays, then writes the caller's paths from copies of them and drops the collected set once the
90
+
finalization is journaled (ADR 0024 2.3). Chunk paths the finalizer refused are removed. A stop that dies before the export exists leaves it absent with the pulled set in
89
91
place, and the next stop resumes from that set instead of signalling a `screenrecord` process that
90
92
already stopped and pulling a file that may have moved since. The 180s platform-limit disclosure now
91
93
travels with the recorder's own observation rather than with the export, so a stop that has to be
0 commit comments