Repository navigation
Commit e407ad3
committed
docs(eager-closure): state deletedSourcesSince's real rename semantics
Approval-round note on PR #3298: plain `git diff` pairs renames by DEFAULT, and
--diff-filter=D drops the paired ones, so the docstring's "WITHOUT -M, so a
rename the similarity detector would pair stays visible" had it backwards --
the list covers only deletions pairing did NOT absorb, and paired renames are
answered by renamedSince. Captured the maintainer's companion constraint too:
dropping the default pairing (--no-renames) would put a re-homed hub in the
deleted set and refuse the very splits the tolerance exists for. Fixed at the
three siblings carrying the same claim: the function docstring, the rule's
deletedSourceTexts field doc, and the gate's cost comment.1 parent 0749922 commit e407ad3
4 files changed
Lines changed: 17 additions & 10 deletions
File tree
- docs/adr
- scripts/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
| 158 | + | |
| 159 | + | |
159 | 160 | | |
160 | 161 | | |
161 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
62 | 66 | | |
63 | 67 | | |
64 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| |||
0 commit comments