You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e0ebab3
Browse filesBrowse the repository at this point in the historyBrowse files
test(coverage): fix what the deletion pins claimed
Two review threads survived #3486 and #3492 because both were merged while the
checks were still queued.
The second deletion case was named for a function whose own lines did not
change, and its own fixture deletes a line inside that function. Renamed to the
scenario it covers: additions below the span, alongside a removal inside it.
The third case pinned its fixture rather than any scoping rule, since a function
absent from the map is unscored in either scope. Measured that first: a stale
map which still records the deleted function yields nothing from `--all`
either, so no scoping keeps it uncharged — the removal takes the score with it.
The test now asserts that in both scopes and says which of the two mechanisms it
is evidence for.
CONTRIBUTING said removing code retires debt. It does not always: dropping lines
that used to be covered lowers the coverage side of the ratio and can raise the
score, and that debt lands in the `--all` backlog rather than the PR. The
sentence now says deletions are uncharged, which is the accurate claim, and
names where the debt it can create goes.
Part of #3414.
0 commit comments