Skip to content

Commit dca9be9

Browse files
committed
fix: drop deleted repo-health file from the retry list after #1480
Rebase onto main post-#1480: the SkillGym/repo-health descope deleted scripts/repo-health/run.test.ts, whose CONTENTION_RETRY_FILES entry would now fail this PR's own missing-file check, and inlined the slow-test budgets into the reporter, resolving the budgets-module import. Envelope comments now point at scripts/lib/lane-envelope.ts instead of the closed #1430. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01FUv7bvbWNryuXgSBuqTtep
1 parent 8745544 commit dca9be9

4 files changed

Lines changed: 3 additions & 10 deletions

File tree

‎scripts/lib/contention-retry-lane.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export type TestRun = {
2424
blockers?: readonly RunBlocker[];
2525
};
2626

27-
/** Telemetry payload for scheduled-lane health (#1430). */
27+
/** Telemetry payload written to the shared lane envelope (scripts/lib/lane-envelope.ts). */
2828
export type ContentionRetryTelemetry = {
2929
/** Files rerun in this job (one entry per file, not per failed test). */
3030
retried: ReadonlyArray<{ file: string; testNames: readonly string[]; trackingIssue: string }>;

‎scripts/lib/contention-retry-run.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// Runs Vitest once; if the only failures are timeout-shaped and live in the
66
// enumerated retry list (scripts/lib/contention-retry.ts), reruns exactly those
77
// files once. Every retried file is named in the job summary, and the run writes
8-
// the shared scheduled-lane envelope so retry counts feed lane health (#1430).
8+
// the shared lane envelope (scripts/lib/lane-envelope.ts) so retry counts stay observable.
99

1010
import crypto from 'node:crypto';
1111
import fs from 'node:fs';

‎scripts/lib/contention-retry.ts‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -172,13 +172,6 @@ export const CONTENTION_RETRY_FILES: readonly ContentionRetryEntry[] = [
172172
reviewBy: REVIEW_BY,
173173
serializedStub: true,
174174
},
175-
{
176-
file: 'scripts/repo-health/run.test.ts',
177-
reason: 'Spawns the repo-health CLI over the real tree and waits for it to exit (#1423).',
178-
trackingIssue: 'https://github.com/callstack/agent-device/issues/1423',
179-
reviewBy: REVIEW_BY,
180-
serializedStub: true,
181-
},
182175
{
183176
file: 'src/daemon/__tests__/request-router-open.test.ts',
184177
reason: 'Drives real open routing over keyed locks, waiting on lock/session settle budgets.',

‎scripts/lib/lane-envelope.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Standard artifact envelope for scheduled lanes (issue #1430).
1+
// Standard artifact envelope for scheduled lanes.
22
//
33
// A scheduled lane can go dark or drift for weeks while PR CI stays green, so
44
// every artifact it uploads must say — without a human reading logs — which

0 commit comments

Comments
 (0)