You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit db5d26b
Browse filesBrowse the repository at this point in the historyBrowse files
fix(utils): throw AppError from app-log-files and verified-file guards (#1853)
* fix(utils): throw AppError from app-log-files and verified-file guards
The symlink, not-a-regular-file, identity-changed and identity-race guards
threw plain Error, so they surfaced as UNKNOWN with a misleading hint and
tests could only assert them by message. They are now COMMAND_FAILED with a
recovery hint (ADR 0010); the affected tests assert through
assertThrowsAppError, and the two race guards gain planted-interleaving
coverage.
Closes#1792
* test(utils): pin the recovery hints the AppError conversion added
The tightened assertions supplied only code and message, and the helper did
not look at the hint, so deleting either hint constant left every targeted
test green — vacuous for the half of #1792 that ADR 0010 actually cares
about. assertThrowsAppError/assertRejectsAppError now accept a hint,
checked against normalizeError's view so a dropped hint surfaces as the
misleading per-code default rather than passing, and each guard pins its
exact text as a literal (importing the constant would compare it to
itself).
0 commit comments