Skip to content

Commit db0e084

Browse files
authored
docs: retire plans/phase3-platform-plugin-progress.md; track remaining work in issues (#982)
The remaining Phase 3 Apple PlatformPlugin work (steps b + d) is now filed as GitHub issues under umbrella #972, so the standalone progress plan is redundant and a staleness hazard (it already drifted once re: cost.runnerRoundTrips). - Remove plans/phase3-platform-plugin-progress.md. - Repoint its references at the durable sources: perfect-shape.md (x3) and ADR-0009 now link the Phase 3 tracking issue #972; the plugin.ts step-b facet note points at ADR-0009 (+ issue #974). Design rationale stays in perfect-shape.md and ADR-0009; live status lives in the issues.
1 parent 62b3eb5 commit db0e084

4 files changed

Lines changed: 6 additions & 158 deletions

File tree

‎docs/adr/0009-apple-platform-consolidation.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,5 @@ Implementation status as of 2026-06:
6060
capability tables, and any watchOS unsupported sentinel. watchOS remains out of scope for the current
6161
consolidation.
6262

63-
This ADR owns the architectural decision; implementation progress for the remaining platform-plugin work lives
64-
in `plans/phase3-platform-plugin-progress.md`.
63+
This ADR owns the architectural decision; implementation progress for the remaining platform-plugin work is
64+
tracked in GitHub issues under the Phase 3 umbrella (#972).

‎plans/perfect-shape.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ but "add a platform" still touches the `device.ts` union line.
293293
already builds `ios|macos|tvos` and ~85% of `platforms/ios` is already the OS-agnostic Apple engine, so this is
294294
mostly relocate-and-rename for iOS/iPadOS/tvOS/macOS; visionOS is scoped net-new work and watchOS is an
295295
explicit unsupported sentinel (XCUITest can't drive it). ADR 0009 owns the AppleOS decision; remaining
296-
implementation state is tracked in [phase3-platform-plugin-progress.md](./phase3-platform-plugin-progress.md).
296+
implementation state is tracked in the [Phase 3 tracking issue #972](https://github.com/callstack/agent-device/issues/972).
297297

298298
### 5.2 `CommandDescriptor` (the command axis) — *facet composition*, honoring ADR 0003
299299

@@ -398,7 +398,7 @@ a step can't ship alone, the plan has failed.
398398
| **0 · confidence builders** (behaviorless) | **(b) ✅ shipped** — exhaustive capability platform selection; **(c) ✅ shipped** — generic `RecordingBackend<P>` (5 casts deleted); (a) parse-at-boundary on MCP/HTTP edge; (d) collapse the 3 platform allow-lists + 5-layer batch validation | low | correctness/security; builds muscle memory; touches no identity table |
399399
| **1 · command spine** | (a) **invert the import graph** — `commandRegistry` becomes root, `command-catalog`/`capabilities`/`daemon-registry`/`batch-policy` derive (parity-tested, no deletion yet); (b) promote each family's facet → `CommandDescriptor` additively; (c) replace the 24-arm switch with the total map, arm-by-arm | **med** (the import-cycle inversion is the real first-week blocker: `command-catalog` has ~95 importers and the facet imports `AgentDeviceClient` today) | finishes a proven seam; add-command → ~2 files; enables everything below |
400400
| **2 · typed results** (the parity oracle) | (a) `CommandResultMap` with `Record` default, migrate per-command from real runner payloads; (b) graft `TypedError`; fold the disowned 'generic' family into `handlers/` **last**; (c) kill the `client-types.ts` mirror (~550 LOC) | med (must be per-command, never a big-bang retype of 203 files) | the safety net the platform unwind needs; biggest single LOC win |
401-
| **3 · platform plugin** (now safe) | (a) define `PlatformPlugin`, **lazy** factories (cold-start benchmark guards latency); (b) move capability columns onto plugin grants, **porting every `supports()` closure verbatim**, pinned by the table-equivalence test before deletion; (c) ✅ unwind macOS and the OS-agnostic Apple engine out of `platforms/ios`; (d) finish Apple plugin facets, tvOS leaf, final `Platform` collapse, and watchOS sentinel last. The **Apple plugin is the first instance** and owns the `AppleOS` leaves — see ADR 0009 and [phase3-platform-plugin-progress.md](./phase3-platform-plugin-progress.md) | **high** (touches shared platform routing and the XCTest runner) | add-platform wiring → ~3 files; kills the 231-branch smear |
401+
| **3 · platform plugin** (now safe) | (a) define `PlatformPlugin`, **lazy** factories (cold-start benchmark guards latency); (b) move capability columns onto plugin grants, **porting every `supports()` closure verbatim**, pinned by the table-equivalence test before deletion; (c) ✅ unwind macOS and the OS-agnostic Apple engine out of `platforms/ios`; (d) finish Apple plugin facets, tvOS leaf, final `Platform` collapse, and watchOS sentinel last. The **Apple plugin is the first instance** and owns the `AppleOS` leaves — see ADR 0009 and the [Phase 3 tracking issue #972](https://github.com/callstack/agent-device/issues/972) | **high** (touches shared platform routing and the XCTest runner) | add-platform wiring → ~3 files; kills the 231-branch smear |
402402
| **4 · agent-cost** (opt-in) | (a) `ResponseView.toView` with `default`==today; `responseLevel` knob defaulting to `default`; (b) typed `BatchStepResult` → intermediate steps digest; per-command MCP `outputSchema`; generalize zero-load fast-paths | med (wire-shape risk vs Maestro — strictly opt-in) | the north-star-#2 token/latency wins |
403403
| **5 · layering + legacy** (quiet windows) | intent-folder moves + utils extraction as pure path codemods; at next major drop the ~175 LOC of legacy aliases/barrels | low-per-step, high-diff | scoped ownership + import lint; merge-pain risk → land fast, small |
404404

@@ -433,7 +433,7 @@ grants; bundling the folder reorg with the registry work (maximizes diff-noise a
433433
## 8. Before / after — the command axis
434434

435435
(The platform-axis decision lives in ADR 0009; current implementation status lives in
436-
[phase3-platform-plugin-progress.md](./phase3-platform-plugin-progress.md).)
436+
the [Phase 3 tracking issue #972](https://github.com/callstack/agent-device/issues/972).)
437437

438438
```
439439
BEFORE — a command's identity is RESTATED in ~10 hand-synced tables, aligned "by convention"

‎plans/phase3-platform-plugin-progress.md‎

Lines changed: 0 additions & 152 deletions
This file was deleted.

‎src/core/platform-plugin/plugin.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import type { CapabilityBucket } from '../platform-descriptor/types.ts';
2323
* (`providers` / `recording` / `appLog` / `perf`) are NOT declared here — they
2424
* arrive in step (b), typed against PLATFORM-NEUTRAL, daemon-owned wrappers
2525
* (not the iOS-simulator-shaped provider seam). See
26-
* plans/phase3-platform-plugin-progress.md.
26+
* docs/adr/0009-apple-platform-consolidation.md (tracked in issue #974).
2727
*/
2828
export type PlatformPlugin = {
2929
/** Plugin/family id; also the capability-matrix bucket key for its platforms. */

0 commit comments

Comments
 (0)