Skip to content

Commit daf419a

Browse files
committed
perf(ios): avoid bundling acquired snapshot path
1 parent 153f97f commit daf419a

3 files changed

Lines changed: 5 additions & 20 deletions

File tree

‎packages/capture-kit/src/ios-snapshot-engine/index.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ export {
44
presentIosSnapshot,
55
publishIosSnapshot,
66
} from './engine.ts';
7+
export { presentIosRunnerSnapshot } from './runner-presentation.ts';
78
export {
89
buildIosInteractiveSnapshotPresentation,
910
presentIosInteractiveSnapshot,

‎packages/capture-kit/src/ios-snapshot-engine/runner-presentation.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { IosSnapshotEngineError } from './types.ts';
99
export function presentIosRunnerSnapshot(
1010
input: Extract<IosSnapshotInput, { stage: 'presented' }>,
1111
request: IosSnapshotRequest,
12-
foldPolicy: IosSnapshotFoldPolicy,
12+
foldPolicy: IosSnapshotFoldPolicy = 'cursor-projected',
1313
): IosSnapshotEnginePresentation {
1414
validateRunnerRequest(input, request);
1515
const projection = input.validation.presentationKey.projection;

‎packages/platform-apple/src/runner/snapshot-presentation.ts‎

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
import type {
2-
IosAcquisitionResidue,
32
IosRunnerQualityPayloadFacts,
43
IosSnapshotInput,
54
IosViewportEvidence,
65
} from '@agent-device/contracts/ios-snapshot';
76
import type { SnapshotOptions } from '@agent-device/contracts/interactor-types';
87
import { normalizeType } from '@agent-device/contracts/snapshot';
98
import {
10-
publishIosSnapshot,
119
IosSnapshotEngineError,
10+
presentIosRunnerSnapshot,
1211
} from '@agent-device/capture-kit/ios-snapshot-engine';
1312
import { readSnapshotQualityVerdict } from '@agent-device/capture-kit/snapshot-quality-verdict';
1413
import {
@@ -82,12 +81,12 @@ export function presentAppleRunnerSnapshot(
8281
viewport,
8382
hittability: { kind: 'available' },
8483
lineage: { targetId: deviceId },
85-
residue: runnerResidue(result),
84+
residue: [],
8685
},
8786
};
8887

8988
try {
90-
return [...publishIosSnapshot(input, request).payload.nodes];
89+
return presentIosRunnerSnapshot(input, request).nodes;
9190
} catch (error) {
9291
throwSnapshotEngineError(error);
9392
}
@@ -152,21 +151,6 @@ function rectArea(rect: RawSnapshotNode['rect']): number {
152151
return rect ? rect.width * rect.height : 0;
153152
}
154153

155-
function runnerResidue(result: AppleRunnerSnapshotResult): IosAcquisitionResidue[] {
156-
const residue: IosAcquisitionResidue[] = [];
157-
if (result.truncated === true || result.qualityPayload?.truncated === true) {
158-
residue.push({ kind: 'truncated', dimension: 'payload' });
159-
}
160-
if (result.quality?.effectiveDepth !== undefined) {
161-
residue.push({
162-
kind: 'truncated',
163-
dimension: 'depth',
164-
limit: result.quality.effectiveDepth,
165-
});
166-
}
167-
return residue;
168-
}
169-
170154
function isRecord(value: unknown): value is Record<string, unknown> {
171155
return typeof value === 'object' && value !== null && !Array.isArray(value);
172156
}

0 commit comments

Comments
 (0)