You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d969e79
Browse filesBrowse the repository at this point in the historyBrowse files
fix(settle): rule the dismissed-surface check out once, and qualify its help
Review on #3512:
- the null answer is a real answer: '??=' reran the chrome classification on every poll for
the ordinary full-screen baseline, which is the case the whole point is to keep cheap
- the 1500ms floor is iOS XCTest-only and bounded by the settle deadline, so neither the CLI
flag nor the MCP schema field may state it as universal
- the comment said a short-window caller is held to 'its own window rather than the fixed
floor', which is the opposite of what Math.max(requested, 1500) does
- the navigation fixtures are compact projections, not the 24-34 nodes a live screen reports;
the comment claimed otherwise
- the longpress case budgets for the confirmation without asserting it, so it could not catch
the baseline failing to reach the loop
'Settle: quiet window the UI must hold to count as settled (default 500ms). A dismissed modal or alert is confirmed for at least 1500ms regardless',
214
+
'Settle: quiet window the UI must hold to count as settled (default 500ms). On iOS, dismissing a presented surface (alert or sheet) holds at least 1500ms, within the --timeout settle deadline',
Copy file name to clipboardExpand all lines: src/commands/post-action-observation-grammar.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -34,7 +34,7 @@ const settleFields = () => ({
34
34
'After the action, wait for the UI to go quiet and return the settled diff vs the pre-action tree in the same response. Best-effort; never fails the action.',
35
35
),
36
36
settleQuietMs: integerField(
37
-
'Settle: quiet window in milliseconds (default 500). A dismissed modal or alert is confirmed for at least 1500 regardless.',
37
+
'Settle: quiet window in milliseconds (default 500). On iOS, dismissing a presented surface (alert or sheet) holds at least 1500, within the timeoutMs settle deadline.',
38
38
{min: 0},
39
39
),
40
40
timeoutMs: integerField('Settle: wait deadline in milliseconds (default 10000).',{min: 1}),
0 commit comments