Skip to content

Commit d9078a5

Browse files
tooling-only owner projection for command descriptors and daemon routes
- Remove ownerFiles from CommandDescriptor and RAW_COMMAND_DESCRIPTORS. - Add commandDescriptorOwners in registry.ts as a tooling-only Record<Command, ...>. - Remove ownerFile from DAEMON_ROUTE_HANDLERS defineDaemonRoute. - Add DAEMON_ROUTE_OWNER_FILES as tooling-only const in request-handler-chain.ts. - Update explain:command and tests to merge projections. - Treeshaking drops owner metadata from production bundles. Fixes #1178. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 parent ae74c51 commit d9078a5

6 files changed

Lines changed: 129 additions & 110 deletions

File tree

‎src/commands/__tests__/command-explain.test.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@ import { execFileSync } from 'node:child_process';
22
import fs from 'node:fs';
33
import path from 'node:path';
44
import { describe, expect, test } from 'vitest';
5-
import { commandDescriptors } from '../../core/command-descriptor/registry.ts';
5+
import {
6+
commandDescriptors,
7+
commandDescriptorOwners,
8+
} from '../../core/command-descriptor/registry.ts';
69
import { getDaemonRouteOwnerFiles } from '../../daemon/request-handler-chain.ts';
710
import {
811
explainCommand as explainCommandFromMetadata,
@@ -165,7 +168,7 @@ describe('explainCommand table-driven coverage', () => {
165168
const result = explainCommand(descriptor.name, { fileExists });
166169
expect(result.found).toBe(true);
167170
if (!result.found) continue;
168-
for (const ownerFile of descriptor.ownerFiles) {
171+
for (const ownerFile of commandDescriptorOwners[descriptor.name]) {
169172
expect(result.explanation.files).toContain(ownerFile);
170173
}
171174
for (const file of result.explanation.files) {

‎src/commands/command-explain.ts‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@ import { listCliCommandNames } from '../command-catalog.ts';
22
import { cliAliasesForCommand, normalizeCliCommandAlias } from '../cli-command-aliases.ts';
33
import { buildCommandUsage } from '../utils/cli-usage.ts';
44
import type { DaemonCommandRoute } from '../daemon/daemon-command-registry.ts';
5-
import { commandDescriptors, type Command } from '../core/command-descriptor/registry.ts';
5+
import {
6+
commandDescriptors,
7+
commandDescriptorOwners,
8+
type Command,
9+
} from '../core/command-descriptor/registry.ts';
610
import type { CommandCapability } from '../core/capabilities.ts';
711
import type { CommandTimeoutPolicy } from '../core/command-descriptor/types.ts';
812
import {
@@ -121,7 +125,7 @@ function buildCommandExplanation(
121125
...(cliSchema ? { cli: describeCliSurface(descriptor.name, cliSchema) } : {}),
122126
files: commandFiles(
123127
descriptor.name,
124-
descriptor.ownerFiles,
128+
commandDescriptorOwners[descriptor.name],
125129
family?.name,
126130
'daemon' in descriptor ? descriptor.daemon?.route : undefined,
127131
Boolean('capability' in descriptor && descriptor.capability),

0 commit comments

Comments
 (0)