Repository navigation
Commit d71441e
authored
fix(ios): observe fill once without destructive repair (#3334)
* fix(ios): stop fill from failing and repairing fields that normalize their input (#2634)
The bug was textEntryValueEchoes' containment clauses, not the repair gate.
A field that reformats what it holds (a '## ### ## ##' digit grouping, a
phone mask, a currency format) shows the request with the formatter's
separators inserted; clauses 2/3 classify that as an echo, which withheld
the unconfirmed outcome, so the fill fell to mismatch -> destructive
clear-and-retype of a correct field -> TEXT_ENTRY_MISMATCH. Measured on
iPhone 18 Pro / iOS 27.0 against a digit-grouping fixture:
REPAIR_TEXT_ENTRY expectedLength=9 observedLength=12, then the mismatch.
A value that COMPLETES the request now falls through to the existing
unconfirmed-evidence path: every request character in order, plus inserted
characters strictly between the request's own characters that appear
nowhere in the request. Degradation removes; entry cannot insert a
separator between two characters the same burst typed, and a failed
clear leaves residual text at the ENDS of the typed run — so end-only
insertions ('old123456') stay echoes and keep their repair, while an
interior foreign insertion does not. Leftmost embedding and a
no-request-character-extras guard keep doubled entries and ambiguous
embeddings on the failure side.
This deliberately flips the pin that '(555) 123-4567' IS an echo: 'echo'
means 'could be a degraded copy', and a complete mask value is not one.
Completion is never a correctness claim — a cents-shifting mask passes it
— so the outcome is unconfirmed with before/after evidence, never
verified: true; only exact equality verifies. fill-evidence.ts already
names app-owned formatting as this shape's purpose; Android already
reports it unconfirmed; iOS was the outlier.
isRepairableTextEntryMismatch and the synthesized-replacement commit wait
are UNCHANGED; the coordinate route's exact-match-only settle is pinned as
an explicit non-goal. The write-back-truncation shape (ada@example ->
adxe) stays a typed failure under #2903's ownership, and so do drops,
stale residuals, and doubled entries.
Fixture: AgentDeviceDigitGroupingTextField reproduces the reported
formatter and restores the caret across reformats the way the real
formatter it models does; both normalizing device tests share one
fill-and-assert helper so their plumbing cannot drift. The device test
proves the repair no longer runs (message 'typed', not 'typed after
repair') and the field keeps 00 062 91 77.
* test(ios): pin the completion rule's residual provenance on both sides (#2634 review)
Adds the reviewer-requested classifier-table pair: baseline "12" refuses
"12 567 8" for request "5678", while an absorbed residual (baseline "12",
observed "(555) 123-4567") completes because every extra is punctuation the
baseline cannot explain. The evidence level gains the same positive, so the
rule is pinned as keyed on extra provenance, not baseline emptiness. Tightens
the completion predicate's doc to match.
* docs+test(ios): pin the template-retaining mask as the completion rule's known limit (#2634 review)
The docs and help claimed a normalizing field is always typed once; a mask
that keeps its template through the clear ("$0.00" before "$10.00") shares
characters with the value it formats, so its fill still takes the echo
reading with its repair — text cannot tell surviving template from
failed-clear residual, which is the same relation the residual fix relies
on. Pin the exact triple at the completion-table and evidence levels, state
the boundary in the docs/help and the predicate doc, and drop the orphaned
one-character-request comment left above the span bounds when the count
guard moved into the opening guard.
* fix(ios): observe fill once without destructive repair
* fix(ios): preserve fill settling after slow reads
* docs+test(ios): scope the submit-key guarantee to the same target; state table outcomes (#3334 review)
The identity guard in replacementTextEntryResult returns TEXT_ENTRY_MISMATCH
for a read resolving to a different element before the submit-key exception
is reached, so the published guarantee's 'any non-matching value' is scoped
to values observed on the same target in both surfaces that state it. The
slow-read table's expected unconfirmed after-value becomes an explicit per-
row literal instead of a check derived from the row's own input.1 parent ca227e2 commit d71441e
13 files changed
Lines changed: 560 additions & 226 deletions
File tree
- apple/runner/AgentDeviceRunner
- AgentDeviceRunnerUITests
- UnitTests
- AgentDeviceRunner
- packages/contracts/src
- src/commands
- interaction
- schema
- website/docs/docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| 74 | + | |
74 | 75 | | |
75 | 76 | | |
76 | 77 | | |
| |||
97 | 98 | | |
98 | 99 | | |
99 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
100 | 217 | | |
101 | 218 | | |
102 | 219 | | |
| |||
202 | 319 | | |
203 | 320 | | |
204 | 321 | | |
205 | | - | |
| 322 | + | |
206 | 323 | | |
207 | 324 | | |
208 | 325 | | |
209 | | - | |
| 326 | + | |
| 327 | + | |
210 | 328 | | |
211 | 329 | | |
212 | 330 | | |
| |||
292 | 410 | | |
293 | 411 | | |
294 | 412 | | |
| 413 | + | |
295 | 414 | | |
296 | 415 | | |
297 | 416 | | |
| |||
408 | 527 | | |
409 | 528 | | |
410 | 529 | | |
411 | | - | |
412 | | - | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
413 | 552 | | |
414 | 553 | | |
415 | 554 | | |
| |||
434 | 573 | | |
435 | 574 | | |
436 | 575 | | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
437 | 592 | | |
438 | 593 | | |
439 | 594 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
522 | 522 | | |
523 | 523 | | |
524 | 524 | | |
525 | | - | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
| 525 | + | |
| 526 | + | |
530 | 527 | | |
531 | 528 | | |
532 | 529 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
| 66 | + | |
| 67 | + | |
70 | 68 | | |
71 | 69 | | |
72 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
53 | 77 | | |
54 | 78 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
| 79 | + | |
| 80 | + | |
59 | 81 | | |
60 | 82 | | |
61 | 83 | | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
71 | 91 | | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
77 | 110 | | |
78 | 111 | | |
79 | 112 | | |
| |||
0 commit comments