Repository navigation
Commit d387a45
fix(settle): compare post-action trees in one view across every route (#4500)
* fix(settle): never diff a settle against a full-tree snapshot
After a full snapshot (no -i), the settle diff compared that tree with the
interactive view the settle loop reads, so every wrapper node the view omits
read as removed while nothing changed. The baseline now carries whether it is
a full view, and such a settle diffs from its own settled capture and says so
in its hint. Later settles diff interactive against interactive.
Fixes #4486
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(settle): keep loop hints beside the full-view baseline hint
Address review: the full-view hint replaced the loop hint (such as the
tiny-tree readiness hint) instead of joining it, the wording could read as
diffing against the full view, and the interactive-baseline test used a tree
that held the full-view wrapper.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(settle): mark only a full-view ref frame, not selector captures
Address review: selector resolution captures are full trees and fed the
settle baseline through preAction, so marking every non-interactive
presentation reset every selector-targeted settle to +0 -0. Only the ref
frame the agent read as a full snapshot is marked now; selector and
generic-route baselines keep their diff.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* refactor(settle): keep resolveSettleHint beside its doc comment
Address review: the new hint helper sat between resolveSettleHint and its
JSDoc.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(settle): list additions against a full-view ref frame
Address review: resetting the baseline to the settled capture made every
settle after a full snapshot report +0 -0, even when the press navigated.
The diff now runs against the full ref frame and lists only added lines: the
interactive view adds no node of its own, so additions are evidence, while
removals of nodes that view never reads are not.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* test(settle): pin the added-line count after a full-view baseline
Address review: the every() check passed on an empty line list. The settle
comment now states that only Android's interactive view adds no node of its
own; an iOS row rewrite can still read as added, as before.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(settle): mark omitted removals with a typed flag
Address review: a forced removals count of 0 read as a fact. The settle diff
now carries removalsOmitted, the text verdict prints "removals not listed",
the hint no longer promises a baseline the ref frame may not advance to, and
the docs note the iOS row-rewrite limit.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(settle): settle on the full tree after a full snapshot
Address review: listing only additions against a full-tree baseline still
reported the keyboard window as added, because the interactive view reads
windows the full tree does not. A settle on refs from a full snapshot now
captures the full tree too, so its diff compares one view and issues
full-tree refs. The removals flag, hint and formatter change are gone.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(settle): mark only a whole full-tree ref frame, without a tail
Address review: a scoped, depth-limited or raw frame is a projection the
settle capture does not reproduce, so only an unprojected full snapshot is
marked fullView. Point taps keep the session baseline unmarked. A full-tree
settle carries no tail, because the tail names interactive targets. Comments
now describe the full-tree path.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(settle): keep the tail on a full-tree settle
An unchanged full-tree settle without a tail handed back no refs, so the next
@ref press hit an expired frame. The tail stays, listing addressable refs from
the full-tree view the agent chose.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(settle): leave --actions ref frames on the interactive settle view
Address review: custom actions are another projection the settle capture does
not reproduce, like scope, depth and raw.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(settle): compare post-action trees in one view across every route
A settle diff compared whatever pre-action tree it found with an
interactive settle capture, so a full snapshot, a selector fallback or a
full tree a selector read stored showed up as false removals (#4486).
One rule now owns every post-action comparison: two trees are compared
only when they were read in the same presentation. capture-kit's
postActionBaseline picks the baseline in the agent's view, the
presentation of the ref frame it last read, and SurfaceScopedNodes carries
that presentation. The settle loop captures in it for press, click, fill,
longpress, scroll and back, on refs, selectors and coordinates. --verify
captures in the pre-action tree's view, and diff snapshot starts a new
baseline when the stored tree was read in another view.
Fixes #4486
Co-Authored-By: Claude Opus 5.5 <[email protected]>
* fix(snapshot): preserve view options and lazy baseline imports
* fix(snapshot): retain default views and surface transition evidence
---------
Co-authored-by: Claude Opus 5.5 <[email protected]>1 parent 38b40be commit d387a45
18 files changed
Lines changed: 527 additions & 72 deletions
File tree
- packages
- capture-kit/src
- command-runtime/src/commands
- capture/runtime
- interaction/runtime
- contracts/src
- daemon/src/execution
- kernel/src
- test/integration/provider-scenarios
- website/docs/docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
36 | 89 | | |
37 | 90 | | |
38 | 91 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
3 | 11 | | |
4 | 12 | | |
5 | 13 | | |
6 | | - | |
| 14 | + | |
| 15 | + | |
7 | 16 | | |
8 | 17 | | |
9 | 18 | | |
| |||
16 | 25 | | |
17 | 26 | | |
18 | 27 | | |
19 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
20 | 32 | | |
21 | 33 | | |
22 | 34 | | |
| |||
25 | 37 | | |
26 | 38 | | |
27 | 39 | | |
| 40 | + | |
28 | 41 | | |
29 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
138 | | - | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
139 | 144 | | |
140 | 145 | | |
141 | 146 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
| 9 | + | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
11 | 18 | | |
12 | 19 | | |
13 | 20 | | |
| |||
81 | 88 | | |
82 | 89 | | |
83 | 90 | | |
84 | | - | |
85 | | - | |
86 | | - | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
87 | 102 | | |
88 | 103 | | |
89 | 104 | | |
| |||
92 | 107 | | |
93 | 108 | | |
94 | 109 | | |
95 | | - | |
96 | | - | |
| 110 | + | |
| 111 | + | |
97 | 112 | | |
98 | 113 | | |
99 | 114 | | |
| |||
104 | 119 | | |
105 | 120 | | |
106 | 121 | | |
107 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
108 | 127 | | |
109 | 128 | | |
110 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
121 | | - | |
122 | | - | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
123 | 124 | | |
124 | 125 | | |
125 | | - | |
| 126 | + | |
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
75 | 81 | | |
76 | 82 | | |
77 | 83 | | |
| |||
82 | 88 | | |
83 | 89 | | |
84 | 90 | | |
| 91 | + | |
85 | 92 | | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
90 | 107 | | |
91 | 108 | | |
92 | 109 | | |
| |||
0 commit comments