You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ce49ed1
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: docs/adr/0012-interactive-replay.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -66,7 +66,7 @@ An inserted or removed wrapper ancestor changes identity.
66
66
Replay classifies every annotated step before dispatch through six exact verification paths.
67
67
Only a verified result sends the action.
68
68
Anything that the evidence cannot isolate is an `identity-unverifiable` divergence, never a silent pick.
69
-
The recorder must never emit a payload that its parser rejects. If bounded evidence still exceeds the payload limit, the writer downgrades it to `verification: "unverifiable"`instead of writing an invalid script.
69
+
The recorder must never emit a payload that its parser rejects. The writer downgrades oversized evidence to `verification: "unverifiable"`and drops its rect. Escape-heavy values can still exceed the serialized limit; the implementation does not recheck after dropping the rect.
70
70
The format is additive. Old readers ignore the comment, and new readers run unannotated actions without the check.
71
71
An annotation binds only to the next physical action line.
72
72
@@ -97,7 +97,7 @@ Resume is `replay --from N --plan-digest <sha>`.
97
97
`N` is a 1-based index into the fully expanded executable plan.
98
98
`test` rejects `--from`, because a suite run must remain full and deterministic.
99
99
`planDigest` covers the canonical expanded plan, including identity evidence and the effective target, so an edit cannot silently change ordinal N's target.
100
-
Resume reconstructs no state: preflight rejects a resume that skips an `outputEnv` producer or enters runtime control flow.
100
+
Resume reconstructs no state. Maestro preflight rejects a resume that skips an `outputEnv` producer or enters runtime control flow.
101
101
`resume.allowed` describes plan resumability only. `resume.repairSessionHeld` is the only session-lifetime signal.
102
102
`resume.alternateFrom` offers the recorded-correction ordinal for dual-path hints.
103
103
@@ -107,7 +107,7 @@ The loop is:
107
107
2. Read the divergence.
108
108
3. Repair the app state.
109
109
4. Replay with the reported plan digest and index.
110
-
If you completed the failed action manually, use the next index: `from` for `record-and-heal`, or `alternateFrom` for `caution`/`manual`.
110
+
If you completed the failed action as a recorded action, use the next index: `from` for `record-and-heal`, or `alternateFrom` for `caution`/`manual`.
111
111
112
112
An edited script requires a fresh full replay and a new digest.
113
113
The [divergence and resume contract](../../packages/ad-replay/docs/divergence-and-resume.md) owns the fields, bounds, redaction, surfaces, ordinals, watermark, and digest.
@@ -201,5 +201,5 @@ The [divergence construction contract](../../packages/replay-port/docs/replay-di
201
201
202
202
- Deterministic state reconstruction for resume needs a separate specification and tests.
203
203
- The replay benchmark arm of decision 5 is deferred.
204
-
-A `--force`/`--overwrite` override for `--save-script` publication is out of scope (#1258). Automatic versioned healed names are also out of scope.
204
+
- Automatic versioned healed names are out of scope.
205
205
- Read-only coverage stays deferred for `is exists`, `is absent`, `wait absent`, read-only `find`, and `wait` forms without an element target.
Copy file name to clipboardExpand all lines: docs/adr/0020-composable-recorded-fragments.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -303,7 +303,7 @@ The absolute resolved filesystem path is excluded.
303
303
Therefore, a child move keeps the child digest, but it requires an explicit parent locator edit and parent repin.
304
304
305
305
The digest excludes session timestamps, device names, absolute source paths, and ordinary comments.
306
-
Native `${VAR}` placeholders remain unresolved in the digest, as ADR 0012's late-bound-value rule requires.
306
+
Native `${VAR}` placeholders remain unresolved in the digest, as the [plan digest contract](../../packages/ad-replay/docs/divergence-and-resume.md#plan-digest) requires.
307
307
Maestro's effective static environment and parse-time expansion continue to participate in the Maestro plan digest under ADR 0015.
308
308
A changed target annotation changes the digest because the annotation changes execution-time verification.
309
309
The reason is not that the annotation is diagnostic text.
@@ -663,7 +663,7 @@ This is the intentional v1 tradeoff: stale reuse stays visible, and multiple flo
663
663
Screen identity is app semantics.
664
664
A caller-selected, identity-bearing landmark reuses the verified `wait` contract, and no cross-platform fingerprint is necessary.
665
665
-**Expand all fragments into one flat global plan: rejected.**
666
-
ADR 0012's Maestro include incident showed that expansion-only provenance shifts ordinals and loses the included source boundary.
666
+
The [divergence provenance contract](../../packages/ad-replay/docs/divergence-and-resume.md#report-fields) preserves source files and lines through Maestro includes, where expansion can shift ordinals and lose the included source boundary.
667
667
A nested plan may execute actions in order, but it must retain the fragment address at every step.
668
668
-**Use path-only or floating includes: rejected.**
669
669
A shared file can change between authoring and replay.
- For `record-and-heal`, `from` is the index of the failed step **+ 1** (N + 1).
127
-
The agent performs that step manually before it resumes.
127
+
The agent performs that step as a recorded action before it resumes.
128
128
A resume AT that step would diverge again on the exact step that the agent just completed.
129
129
- For `state-repair`, `caution`, and `manual`, `from` remains **N**.
130
130
@@ -140,11 +140,9 @@ For `caution`/`manual`, there are two legitimate repairs, and the daemon cannot
140
140
- App-state fix: use `--no-record`, then repeat unchanged step N at `from`.
141
141
- Recorded correction: perform step N's intent as a recorded action, then continue at N + 1.
142
142
143
-
`alternateFrom` carries N + 1 only if that request passes `evaluateReplayResumePreflight({ from: N + 1, actions }).allowed`.
144
-
Step N must itself be safe to skip.
145
-
A `runScript``outputEnv` producer or runtime control flow therefore prevents this alternate.
146
-
The alternate preflight examines a strict superset of the primary range.
147
-
Thus, `alternateFrom` implies `allowed: true`.
143
+
`alternateFrom` carries N + 1 for these hints when it is in range, or when a live session can authorize an empty tail.
144
+
The builder does not run a separate plan-safety preflight for the alternate.
145
+
The `ReplayResumeCheck` list validates range, corrective action growth, and digest on the resume request.
148
146
`record-and-heal` omits it because `from` already carries N + 1.
149
147
`state-repair` omits it because it has no recorded-action alternate.
150
148
Text renders the N + 1 command **if and only if `alternateFrom` exists**.
@@ -159,10 +157,10 @@ An armed transaction becomes `COMPLETE`, which permits its later `close` commit.
159
157
Otherwise, `close` would abort the incomplete transaction and discard the correction.
160
158
161
159
This ordinal requires authorization from the exact session and target that produced it.
162
-
The daemon stamps a per-session watermark (`expectedFrom`, the recorded action count at divergence time) in these cases:
160
+
The daemon stamps a per-session watermark (`expectedFrom`, the authorized resume ordinal, and `actionsCountAtDivergence`, the recorded action count at divergence time) in these cases:
163
161
164
162
- For `record-and-heal` with `allowed: true`, the reported `from` is already N + 1.
165
-
- For a preflight-safe `caution`/`manual` final-step alternate, the watermark uses `alternateFrom` N + 1.
163
+
- For a `caution`/`manual` final-step alternate, the watermark uses `alternateFrom` N + 1.
166
164
The primary `from` remains N.
167
165
168
166
Only a live session can receive this watermark.
@@ -215,7 +213,7 @@ Thus a consumer must not read `allowed: true` as "the session is still there."
215
213
## Preflight
216
214
217
215
Resume reconstructs no execution state.
218
-
For `N > 1`, preflight must reject with `INVALID_ARGS` under either condition:
216
+
For Maestro plans and `N > 1`, preflight rejects with `INVALID_ARGS` under either condition:
219
217
220
218
- A skipped action can produce `outputEnv` values.
221
219
- The skipped range or resume target is inside runtime conditional, retry, or dynamic-repeat control flow.
0 commit comments