Skip to content

Commit ca50809

Browse files
committed
docs: align skills/ format policy and purge last SkillGym mention
Address both P2 review findings on #1480: the testing-matrix row and the selector's formatGate both still claimed oxfmt covers skills/, while selectChecks classifies skills/*.md docs-only (oxfmt ignores **/*.md, so the claim was a no-op even before). The matrix now states the docs-only policy and formatGate drops the dead underSkills fact. The merged examples/README.md index (from #1469) loses its skillgym mention. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01FUv7bvbWNryuXgSBuqTtep
1 parent eb7b904 commit ca50809

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

‎docs/agents/testing.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ The mapping it encodes, for when you need to run a gate directly or reason about
1919
| CLI help/guidance (`src/cli/parser/cli-help.ts`, `src/cli-schema/`) | `pnpm exec vitest run src/cli/parser/__tests__ src/cli-schema/command-schema-guards.test.ts scripts/__tests__` — the `scripts/__tests__` gates enforce help-topic benchmark coverage and pin the bench's quoted CLI samples to the real renderers |
2020
| Help benchmark cases (`scripts/help-conformance-*.mjs`) | `pnpm exec vitest run scripts/__tests__` (deterministic gates); model-backed: `pnpm bench:help-conformance` (paid LLM calls, local only) |
2121
| `.ad` grammar (`src/replay/script.ts`, gesture arity, replay vars) | `pnpm exec vitest run --project unit-core test/replay-compat` — the frozen replay-compat corpus asserts which released script surfaces still parse; a flipped verdict is edited in `test/replay-compat/manifest.ts`, never in the script. Adding or re-pinning a corpus entry also runs `pnpm check:replay-compat`, which re-derives each entry from its release tag in git history |
22-
| Anything in `src/`, `test/`, `skills/` | `pnpm format` |
22+
| Anything in `src/`, `test/` | `pnpm format` (`skills/` is Markdown-only guidance: oxfmt ignores `**/*.md`, and the affected-check selector classifies it docs-only) |
2323
| A decision kernel or its tests (`src/kernel/errors.ts`, `src/daemon/ref-frame.ts`, `src/commands/interaction/runtime/settle.ts`, `src/utils/scroll-edge-state.ts`, `src/selectors/`) | `pnpm mutation:affected --base origin/main` (minutes; GitHub runs it per PR — see the mutation ratchet section) |
2424

2525
Two traps worth naming:

‎examples/README.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,5 @@ way a Node consumer or the agent-device-cloud bridge would. Each file:
3333

3434
## test-app/
3535

36-
[`test-app/`](./test-app) is the Expo dogfood fixture used for `agent-device` and `skillgym`
37-
experiments (see its own [README](./test-app/README.md)) — it is a test fixture, not an SDK usage
38-
example.
36+
[`test-app/`](./test-app) is the Expo dogfood fixture used for `agent-device` experiments (see
37+
its own [README](./test-app/README.md)) — it is a test fixture, not an SDK usage example.

‎scripts/check-affected/model.ts‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ type FileFacts = {
146146
isTs: boolean;
147147
underSrc: boolean;
148148
underTest: boolean;
149-
underSkills: boolean;
150149
isSrcProd: boolean;
151150
};
152151

@@ -156,9 +155,9 @@ function reason(check: CheckId, file: string, rule: string, detail: string): Sel
156155
return { check, path: file, rule, detail };
157156
}
158157

159-
const formatGate: OwnershipRule = ({ file, underSrc, underTest, underSkills }) =>
160-
underSrc || underTest || underSkills
161-
? [reason('format', file, 'gate:format', 'oxfmt covers src/, test/, and skills/')]
158+
const formatGate: OwnershipRule = ({ file, underSrc, underTest }) =>
159+
underSrc || underTest
160+
? [reason('format', file, 'gate:format', 'oxfmt covers src/ and test/')]
162161
: [];
163162

164163
const staticTsGates: OwnershipRule = ({ file, isTs, underSrc, underTest }) =>
@@ -311,7 +310,6 @@ function fileFacts(file: string): FileFacts {
311310
isTs,
312311
underSrc,
313312
underTest: file.startsWith('test/'),
314-
underSkills: file.startsWith('skills/'),
315313
isSrcProd: underSrc && isTs && !isTestPath(file),
316314
};
317315
}

0 commit comments

Comments
 (0)