Skip to content

Commit ca0b402

Browse files
committed
ci(ios): run the pan-duration canary automatically on every PR
gesture-lab.ad (and its new duration assertion) only runs under full:fixture-replays, which is currently dispatch-only in replays-manual.yml — the PR-triggered ios.yml lane runs the smoke tier, and replays-nightly.yml no longer carries device replays at all (#1781 A1). So the #1584 guard could not actually catch a regression automatically. Split the duration check into its own minimal, isolated replay (gesture-pan-duration.ad) and run it as a smoke-tier step in ios.yml, so it's cheap and doesn't depend on gesture-lab.ad's multi-touch commands, which stay full-tier only.
1 parent 7b9f1a2 commit ca0b402

3 files changed

Lines changed: 35 additions & 0 deletions

File tree

‎.github/workflows/ios.yml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,17 @@ jobs:
209209
pnpm gate build
210210
node --experimental-strip-types scripts/node-test-tmpdir.ts --test test/integration/smoke-ios-simulator-coverage.test.ts test/integration/smoke-ios-simulator.test.ts
211211
212+
# #1584: isolated, cheap automatic guard for the #1562 class of regression (iOS silently
213+
# ignoring a `gesture pan` duration). Split out of gesture-lab.ad, which stays full-tier
214+
# (dispatch-only via replays-manual.yml) because its multi-touch commands are a separate,
215+
# heavier concern. This is the only automatic lane this assertion runs in today.
216+
- name: Run gesture pan-duration smoke replay
217+
run: |
218+
xcrun simctl install "${{ steps.ios-simulator.outputs.simulator-udid }}" "${{ steps.fixture-app.outputs.app-path }}"
219+
pnpm clean:daemon
220+
node --experimental-strip-types src/bin.ts test examples/test-app/replays/gesture-pan-duration.ad --udid "${{ steps.ios-simulator.outputs.simulator-udid }}" --retries 2 --artifacts-dir test/artifacts/replays-ios-gesture-pan-duration --report-junit test/artifacts/replays-ios-gesture-pan-duration.junit.xml
221+
pnpm clean:daemon
222+
212223
- name: Assert simulator automation preserved host focus
213224
if: ${{ always() }}
214225
run: |

‎examples/test-app/README.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,13 @@ two-pointer gesture changes all three semantic states. On Android, these checks
251251
are intentionally qualitative because recognizers can report non-exact centroid,
252252
scale, and rotation values for one simultaneous two-finger gesture.
253253

254+
`gesture-pan-duration.ad` is a separate, minimal iOS replay that asserts a single-pointer
255+
`gesture pan`'s requested duration is actually observed by the app (a bucketed
256+
`pan duration` status on the Home screen), rather than just that the gesture activated.
257+
It's split out of `gesture-lab.ad` so it can run as an automatic PR-tier check
258+
(`.github/workflows/ios.yml`) without depending on `gesture-lab.ad`'s multi-touch commands,
259+
which stay full-tier only.
260+
254261
To target a specific iOS simulator or an installed Expo development build, run the
255262
underlying command directly so global flags stay before replay inputs:
256263

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Isolated pan-duration canary (#1584), split out of gesture-lab.ad so the smoke tier gets a
2+
# cheap automatic regression guard for #1562 without depending on gesture-lab.ad's multi-touch
3+
# commands (pinch/rotate/transform/two-pointer pan), which are a separate, heavier full-tier
4+
# concern.
5+
context platform=ios kind=simulator timeout=60000
6+
7+
env APP_TARGET="Agent Device Tester"
8+
env APP_URL=""
9+
10+
open "${APP_TARGET}" --relaunch --launch-url "${APP_URL}"
11+
wait "Gesture lab" 30000
12+
wait "gesture canary ready" 5000
13+
14+
gesture pan 110 443 48 0 500
15+
wait text "pan duration >=400ms" 5000
16+
17+
close

0 commit comments

Comments
 (0)