You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c2c7d56
Browse filesBrowse the repository at this point in the historyBrowse files
docs: update guidance references to kernel/{device,errors} after the move
Follow-up to the path move in this PR: AGENTS.md (Apple-family sync rule +
normalizeError), ADR-0009, and plans/apple-platform-consolidation.md still named
the old src/utils/{device,errors}.ts paths. Point them at src/kernel/ so future
agents do not follow stale paths. plans/perfect-shape.md's utils/device.ts
mention is left as-is — it describes the pre-move diagnosis.
Copy file name to clipboardExpand all lines: AGENTS.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -139,7 +139,7 @@ Command-only flags (like `find --first`) that do not flow to the platform layer
139
139
- Use `keyboard dismiss` for iOS keyboard dismissal; it may tap safe native controls such as `Done` but must not fall back to system back navigation.
140
140
- Do not remove shared snapshot/session model behavior without full migration.
141
141
- Command/device support must come from `src/core/capabilities.ts`.
142
-
- Apple-family target changes must keep `src/utils/device.ts`, `src/core/capabilities.ts`, `src/core/dispatch-resolve.ts`, `src/platforms/ios/devices.ts`, and `src/platforms/ios/runner-xctestrun.ts` in sync.
142
+
- Apple-family target changes must keep `src/kernel/device.ts`, `src/core/capabilities.ts`, `src/core/dispatch-resolve.ts`, `src/platforms/ios/devices.ts`, and `src/platforms/ios/runner-xctestrun.ts` in sync.
143
143
- iOS simulator-set scoping is iOS-specific: do not let `iosSimulatorDeviceSet` hide the host macOS desktop target when `--platform macos` or `--target desktop` is requested.
144
144
- If Swift runner code changes, run `pnpm build:xcuitest`.
145
145
- Use `inferFillText` and `uniqueStrings` from `src/daemon/action-utils.ts`.
@@ -157,7 +157,7 @@ Command-only flags (like `find --first`) that do not flow to the platform layer
157
157
- Request diagnostics belong in `sessions/<effective-session>/requests/<request-id>.ndjson` once the effective session is resolved. The top-level daemon log is for daemon lifecycle/startup and pre-session failures.
158
158
- Session artifact paths are centralized in `src/daemon/session-store.ts`; do not hand-build session log paths in handlers.
159
159
- Do not add ad-hoc stderr/file logging where diagnostics helpers apply.
160
-
- Normalize user-facing failures via `src/utils/errors.ts` (`normalizeError`).
160
+
- Normalize user-facing failures via `src/kernel/errors.ts` (`normalizeError`).
- User-facing errors should be short and actionable: say what failed, why when known, and how to recover. Put recovery steps in `hint` when the action is not obvious, for example restart/retry, use plain screenshot when AX state is unavailable, navigate with coordinates, or inspect logs.
163
163
- If an interaction unexpectedly takes 5+ seconds, inspect the relevant daemon log before attributing it to the app. Check the session `--state-dir``daemon.log` or the failure `logPath` for runner restart, stale session recovery, AX failure, transport retry, or command timeout evidence.
0 commit comments