Repository navigation
Commit bffd99a
committed
fix(daemon): let record stop reach the durable manifest a named session addresses (#3674)
The named-session guard covered every record action, so after a daemon restart — the
exact state #3674 serves — `record stop --session qa` was refused before the on-disk
`screen-recording.resource.json` was read, killing the manifest recovery that `help
record` and commands.md promise. That recovery is only reachable through a named
session: the manifest path derives from the session address, and the lane proves the
manifest's session and device before serving. Start is different: it can only be
answered on a chosen device, so it keeps the pre-selection refusal. Order the guard on
the resolved plan (`plan.kind === 'start'`, still before the app-scope refusal) and pin
both directions: the replayed completed export survives store loss, and a start after
the same loss still refuses on the session. Reverting the guard fails both start pins;
keeping it stop-wide fails the replay pin.
Also complete the refusal taxonomy in commands.md: the session-required family answers
the same event as a reasonless SESSION_NOT_FOUND, so document that branch.1 parent e18e053 commit bffd99a
3 files changed
Lines changed: 69 additions & 6 deletions
File tree
- packages/daemon/src/sessions/handlers
- __tests__
- website/docs/docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | | - | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
12 | 71 | | |
13 | 72 | | |
14 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
103 | | - | |
104 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
105 | 110 | | |
106 | 111 | | |
107 | 112 | | |
| |||
110 | 115 | | |
111 | 116 | | |
112 | 117 | | |
113 | | - | |
114 | 118 | | |
115 | 119 | | |
116 | 120 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
485 | 485 | | |
486 | 486 | | |
487 | 487 | | |
488 | | - | |
| 488 | + | |
489 | 489 | | |
490 | 490 | | |
491 | 491 | | |
| |||
0 commit comments