You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit bfbbf36
Browse filesBrowse the repository at this point in the historyBrowse files
docs(daemon): scope refuse-on-exist contract/comments to ordinary recording too
PR #1235 review blocker: SessionScriptWriter.write's refuse-on-exist publish
is uniform across repair-armed heals AND ordinary (non-repair) open/close
--save-script recording, but the ADR contract and several comments still
read as if only healed repair publication is refused and ordinary recording
keeps the old rename-replace overwrite. Maintainer decision is to keep the
behavior uniform and fix the docs/comments/coverage instead of re-scoping.
- session-script-writer.ts: clarify isRepairArmedWriteBlocked only gates
whether a publish is attempted, not what refuse-on-exist does once it is;
fix write()'s catch-block comment, which claimed no AppError was ever
raised on the ordinary path (now false since refuse-on-exist is uniform);
broaden publishHealedScriptAtomically's doc to state it is write()'s only
publish primitive for every target, referencing the removed
publishOverwriteAtomically and the future --force/--overwrite (#1258).
- session-action-recorder.ts / session-replay-runtime.ts / types.ts: fix
comments claiming an explicit --save-script=<path> (or the
saveScriptDefaultedHealedPath marker) is exempt from the clobber guard;
the guard is uniform regardless of path origin or repair-armed status.
- docs/adr/0012-interactive-replay.md: add a "Scope" paragraph making the
refusal explicitly uniform across repair and ordinary recording, and
extend the decision-6 acceptance-test bullet and migration-plan step 9
bullet to require ordinary-recording no-clobber coverage too.
- session-script-writer.test.ts: add the missing existing-target coverage
for the ORDINARY (non-repair, no saveScriptBoundary) path — refused with
bytes unchanged when the target exists (thrown, since ordinary writes
rethrow AppErrors rather than returning them), and confirmed to still
succeed against an absent target.
No runtime behavior change: publish is still a single uniform exclusive
linkSync for every --save-script target.
0 commit comments