Repository navigation
Commit bf6abb2
* fix(snapshot): stop sibling-sized chrome containers from covering their own region (#2996)
A chrome container published with exactly the frame of a sibling reports that
sibling's footprint instead of a surface drawn over it, but the occlusion pass
read its box as covering evidence. `isFullViewportChromeContainer` only exempts
a container sized to the viewport root, so a container that stops short of it
condemned content on both sides.
Captured live on an iPhone 18 Pro (iOS 27.0) through the shipped publication
path (`buildSnapshotState`): a system app's bottom-bar container matching the
812pt content branch beside it marked 36 of that branch's nodes plus the
navigation bar listed beside it; a JS-tab app's tab-bar badge container matching
the platter content view beside it marked all 13 tab-bar nodes. Both now mark 0
and 2 respectively, the two survivors genuinely under the tab bar, and the
Android IME path is untouched because only the tabbar/toolbar/navigationbar
kinds qualify.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
* refactor(snapshot): own the sibling-sized chrome rule in its own module
Move the #2996 rule and its sibling index out of `snapshot-occlusion.ts` into
`snapshot-sibling-sized-chrome.ts` with the matching test file, and single-source the
chrome-kind question in `snapshot-chrome-kind.ts` so both occlusion exemptions read one
classification. The new modules stay beside their caller: layering policy R73 owns
`capture-kit/src/snapshot/` for the presentation runtime.
* test(snapshot): split the sibling-sized-chrome family out of the occlusion tests
Move the #2996 cases into `snapshot-sibling-sized-chrome.test.ts`, which drives the rule
through `annotateCoveredSnapshotNodes` and pins each published iOS kind shape from one
table. `snapshot-occlusion.test.ts` returns to its merge-base length, clearing the
test-file tripwire. The rule stays inside `snapshot-occlusion.ts`: the eager-closure gate
forbids a new module in the closure of a published entry surface, and that file is one.
* docs(snapshot): name the sibling-frame limit of the chrome exemption
---------
Co-authored-by: Claude Opus 4.8 <[email protected]>
1 parent f7d7f38 commit bf6abb2
2 files changed
Lines changed: 494 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
58 | 78 | | |
59 | 79 | | |
60 | 80 | | |
| |||
71 | 91 | | |
72 | 92 | | |
73 | 93 | | |
74 | | - | |
| 94 | + | |
| 95 | + | |
75 | 96 | | |
76 | 97 | | |
77 | 98 | | |
| 99 | + | |
78 | 100 | | |
79 | 101 | | |
80 | 102 | | |
81 | 103 | | |
82 | 104 | | |
83 | 105 | | |
84 | | - | |
| 106 | + | |
85 | 107 | | |
86 | 108 | | |
87 | 109 | | |
| |||
221 | 243 | | |
222 | 244 | | |
223 | 245 | | |
224 | | - | |
| 246 | + | |
225 | 247 | | |
226 | 248 | | |
227 | 249 | | |
| |||
246 | 268 | | |
247 | 269 | | |
248 | 270 | | |
249 | | - | |
| 271 | + | |
250 | 272 | | |
251 | 273 | | |
252 | 274 | | |
253 | 275 | | |
254 | | - | |
| 276 | + | |
| 277 | + | |
255 | 278 | | |
256 | 279 | | |
257 | 280 | | |
258 | 281 | | |
259 | | - | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
260 | 318 | | |
261 | 319 | | |
262 | 320 | | |
| |||
0 commit comments