Repository navigation
Commit bef8706
fix(ios): fall back when any point-lookup position moved
The point lookup validated a handle only for a candidate at the point,
after the point filter. An input of another type that left the app after
an earlier position's read moved a later input into a position already
read, so the input at the point was never read: the next position read
an input elsewhere, which the filter dropped, and the last position no
longer existed and was skipped. The lookup returned no input without
falling back, so a resolved-coordinate fill failed with
NO_TEXT_INPUT_AT_POINT and a coordinate tap could lose its typing
witness.
Every position now must still exist and every handle must read as its
position's input, at the point or not; otherwise the lookup runs the
per-type queries. A position's existence is read only when its snapshot
fails, so a lookup reads each candidate twice, as before for the input
at the point.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 6711463 commit bef8706
2 files changed
Lines changed: 56 additions & 25 deletions
File tree
- apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests
- UnitTests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
192 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
193 | 198 | | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
194 | 202 | | |
195 | 203 | | |
196 | 204 | | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
197 | 215 | | |
198 | 216 | | |
199 | 217 | | |
200 | | - | |
201 | | - | |
202 | 218 | | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
| 219 | + | |
207 | 220 | | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | 221 | | |
216 | | - | |
217 | 222 | | |
218 | 223 | | |
219 | 224 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
92 | 94 | | |
93 | 95 | | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
94 | 118 | | |
95 | 119 | | |
96 | 120 | | |
97 | 121 | | |
98 | 122 | | |
99 | 123 | | |
100 | 124 | | |
101 | | - | |
102 | | - | |
| 125 | + | |
| 126 | + | |
103 | 127 | | |
104 | | - | |
| 128 | + | |
105 | 129 | | |
106 | 130 | | |
107 | 131 | | |
108 | | - | |
| 132 | + | |
109 | 133 | | |
110 | 134 | | |
111 | 135 | | |
| 136 | + | |
112 | 137 | | |
113 | 138 | | |
114 | 139 | | |
115 | 140 | | |
| 141 | + | |
116 | 142 | | |
117 | 143 | | |
118 | | - | |
119 | | - | |
| 144 | + | |
| 145 | + | |
120 | 146 | | |
121 | 147 | | |
122 | 148 | | |
| |||
0 commit comments