Repository navigation
Commit be48a28
committed
test(alerts): pin the press cutoff's dispatched disclosure; review nits
The independent review of f584e8a returned merge-ready with three
follow-up-scale findings, batched here:
- The documented `dispatched: 'unknown'` press-cutoff failure had no test.
Pinned in the Android suite with the real transport shape: the adb fake
hangs the tap until the 2s action window closes and dies with the
signal; the failure must disclose unknown, never 'no'. Mutation-checked:
flipping the disclosure to 'no' fails the pin.
- The `[timeout]` positional is honored by `alert wait` only — the Apple
acting legs pass fixed runner budgets and the tree legs run their own
lookup/confirm windows; commands.md now says the argument is wait-only
per backend instead of leaving the silence to surprise callers.
- `void device;` in limrunAlertOperationFacts follows the `_device`
convention; the two byte-identical visible-after-press exits collapse
into one helper, keeping the two hints that genuinely differ (latest
read hung vs budget ended unresolved).
No behavior change for any message, reason, or tap.1 parent 71087fb commit be48a28
4 files changed
Lines changed: 61 additions & 24 deletions
File tree
- packages
- platform-android/src
- __tests__
- provider-limrun/src
- website/docs/docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
14 | 17 | | |
15 | | - | |
16 | | - | |
| 18 | + | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| |||
198 | 201 | | |
199 | 202 | | |
200 | 203 | | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
201 | 236 | | |
202 | 237 | | |
203 | 238 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
523 | 523 | | |
524 | 524 | | |
525 | 525 | | |
526 | | - | |
527 | | - | |
528 | | - | |
529 | | - | |
530 | | - | |
531 | | - | |
532 | | - | |
| 526 | + | |
533 | 527 | | |
534 | 528 | | |
535 | 529 | | |
| |||
543 | 537 | | |
544 | 538 | | |
545 | 539 | | |
546 | | - | |
547 | | - | |
548 | | - | |
549 | | - | |
550 | | - | |
551 | | - | |
552 | | - | |
| 540 | + | |
553 | 541 | | |
554 | 542 | | |
555 | 543 | | |
| |||
561 | 549 | | |
562 | 550 | | |
563 | 551 | | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
564 | 567 | | |
565 | 568 | | |
566 | 569 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
276 | 276 | | |
277 | 277 | | |
278 | 278 | | |
279 | | - | |
| 279 | + | |
280 | 280 | | |
281 | 281 | | |
282 | | - | |
283 | 282 | | |
284 | 283 | | |
285 | 284 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
400 | | - | |
| 400 | + | |
401 | 401 | | |
402 | 402 | | |
403 | 403 | | |
| |||
0 commit comments