Repository navigation
Commit be1b89f
committed
fix(apple-runner): report the restart transport fact for a read, not no
The restart path disclosed `no` for a read-only command whose first send
may have run, while the status-recovery path discloses `unknown` for the
same read (read_only_completed_without_retained_response, and the
notAccepted/unknown-state fallthrough). Both runner paths now report the
transport fact: a first attempt that may have written the command is
`unknown`, read or mutation. The read-only `no` has one owner, the daemon
router seam (request-dispatch-disclosure.ts), which keys it on the
registry's recordingEffect `observes-app` for every producer
(daemon.read-only-command). A second copy keyed on the runner's own
read-only trait reconstructed that rule from a different source of truth,
and the two runner paths disagreed. The recycle-budget refusal on the
restart path also stops deriving `no` from the read-only trait and uses
only whether the first attempt was provably unwritten.
The runner still resends a read on the restarted runner
(canResendAfterRestart); only the disclosure changes.
dispatch-disclosure.json:
- ios-runner.transport.read-only-written-then-lost: now `unknown`; the
trigger names the router rule that turns it into `no` for the caller.
- ios-runner.status.read-only-completed-without-retained-reply: new,
`unknown`, driven through the real connect loop and recovery module.
It pins the status-recovery read to the same value as the restart read.
Mutations:
- put back `if (isReadOnlyRunnerCommand(evidence.command)) return
discloseDispatch(error, 'no')` in discloseRestartDispatch ->
read-only-written-then-lost fails.
- set `dispatched: 'no'` on read_only_completed_without_retained_response
-> status.read-only-completed-without-retained-reply fails.1 parent 4708d4f commit be1b89f
3 files changed
Lines changed: 37 additions & 11 deletions
File tree
- contracts/fixtures
- packages/platform-apple/src/runner
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
244 | 244 | | |
245 | 245 | | |
246 | 246 | | |
247 | | - | |
248 | | - | |
| 247 | + | |
| 248 | + | |
249 | 249 | | |
250 | 250 | | |
251 | 251 | | |
| |||
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
280 | 286 | | |
281 | 287 | | |
282 | 288 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| |||
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
69 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
70 | 76 | | |
71 | 77 | | |
72 | 78 | | |
73 | 79 | | |
74 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
75 | 90 | | |
76 | 91 | | |
77 | 92 | | |
78 | 93 | | |
79 | 94 | | |
80 | 95 | | |
81 | | - | |
| 96 | + | |
82 | 97 | | |
83 | 98 | | |
84 | 99 | | |
| |||
175 | 190 | | |
176 | 191 | | |
177 | 192 | | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
178 | 198 | | |
179 | 199 | | |
180 | 200 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
423 | 423 | | |
424 | 424 | | |
425 | 425 | | |
426 | | - | |
| 426 | + | |
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
| |||
529 | 529 | | |
530 | 530 | | |
531 | 531 | | |
532 | | - | |
533 | | - | |
534 | | - | |
535 | | - | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
536 | 537 | | |
537 | 538 | | |
538 | 539 | | |
539 | 540 | | |
540 | 541 | | |
541 | 542 | | |
542 | | - | |
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
| |||
0 commit comments