You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit bd0cae4
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(apple): let the classifier own the launch-log verdict
The connect loop decided a boot was terminal with its own bless-signature check, a copy of the
row's line matching that ignored row order. On a scoped-set launch whose tail held both signatures
the loop stopped while the built error carried `simulator_set_destination_not_found`, whose verdict
was retryable, so each remaining attempt re-threw without dialing until the deadline.
Now the verdict is whatever `classifyRunnerStartupFailure` returns over the tail: a row declares the
cause it names in the message, the classifier returns it, and the loop throws the built error only
when `shouldRetryRunnerConnectError` says a retry cannot help. The scoped-set destination cause gets
the same fast path, the transport knows no hub specifics, and the two message helpers and the
signature predicate are gone.
Refs #3449, #3739 review round 2.
Co-Authored-By: Claude <[email protected]>
return`${message}: xcodebuild found no simulator ${device.id} in simulator set ${details.simulatorSetPath}${details.xcodeVersion===undefined ? '' : ` with Xcode ${details.xcodeVersion}`}`;
hint: 'Check that the simulator still exists in the --ios-simulator-device-set this error names (`xcrun simctl --set <set> list devices`). If it does, the Xcode this error names no longer honors -DVTSimulatorSetLocation, so use a simulator in the default set.',
? `xcodebuild found no simulator ${details.simulatorUdid} in simulator set ${details.simulatorSetPath}${typeofdetails.xcodeVersion==='string' ? ` with Xcode ${details.xcodeVersion}` : ''}`
hint: 'This Xcode cannot start its simulator service on this macOS: macOS refuses to load its DTServiceHub. Select an Xcode that supports this macOS on the daemon host (`xcode-select -s /Applications/Xcode.app`, or DEVELOPER_DIR=/Applications/Xcode.app for the daemon process), then retry. Updating Xcode is the fix; restarting the runner or clearing derived data cannot change it.',
479
+
messageSuffix: ()=>'this Xcode cannot start its simulator service on this macOS',
474
480
},
475
481
},
476
482
{
@@ -802,7 +808,12 @@ export function classifyRunnerStartupFailure(error: unknown): RunnerStartupClass
0 commit comments