You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b9a59ea
Browse filesBrowse the repository at this point in the historyBrowse files
fix(ios): confirm post-tap focus from a signal iOS can actually answer
Adversarial review of the previous commit found that carrying the dispatch point
forward was not enough on its own. On iOS `focusedTextInput` is intentionally
nil, so the readiness wait the tap path calls can never succeed there: it spent
`readinessTimeout` and then repeated the gesture unconditionally. Repeating it at
a point the keyboard may since have moved away from its field is the stale-frame
hazard this repo refuses elsewhere, and on the reported Flutter field the pre-fix
code never reached a second gesture at all, because the failed read aborted the
command first.
Poll for the software keyboard instead, which is the focus evidence iOS gives
without re-reading the resolved element: the wait ends as soon as a keyboard
appears, keeps the same ceiling before repeating the gesture so a merely late
keyboard is not answered with a gesture a healthy app did not need (#1874), and a
keyboard already up at the tap is read as confirmation rather than as a question
the repeat should answer. `waitForFocusedTextInput` had no caller left.
Also reads that could not be observed: `coordinateTapTextInputIdentityAt` now says
when a probe resolved an input whose identity it could not capture, so the
resulting loss of tap-to-type authorization is distinguishable from a point that
held no input, and the two doc comments that over-claimed what the tap-side fix
covers are scoped to what it does.
0 commit comments