Repository navigation
Commit b8fa83c
fix(record): validate finalized iOS device MP4 before reporting record stop success (#1238)
* fix(record): validate finalized iOS device MP4 before reporting record stop success
Physical-iOS `record stop` (runner AVAssetWriter backend) could return a
successful `screen-recording` artifact for an MP4 that was never finalized
(no `moov` atom), because it was the only native recording backend that did
not validate the copied file before reporting success.
Mirror the simulator and Android paths: after the devicectl copy succeeds,
run `deps.waitForStableFile` + `deps.isPlayableVideo` on the output and return
a `COMMAND_FAILED` response (no artifact) when the file is not a playable
video. Also capture the runner-side stop result (`runnerStopOk`) that
`stopRunnerRecordingBestEffort` previously swallowed, fold it into the failure
message, and emit a `record_stop_ios_invalid_video` diagnostic.
Closes #1229
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01M1ZTEJFKv3BAW36VmBwe2v
* test(record): cover iOS video validation through provider flow
* fix(record): surface iOS runner stop failures
---------
Co-authored-by: Matt Van Horn <[email protected]>
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
Co-authored-by: Michał Pierzchała <[email protected]>1 parent b5e0e59 commit b8fa83c
3 files changed
Lines changed: 204 additions & 131 deletions
File tree
- src/daemon/handlers
- __tests__
- test/integration/provider-scenarios
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
802 | 802 | | |
803 | 803 | | |
804 | 804 | | |
805 | | - | |
| 805 | + | |
806 | 806 | | |
807 | 807 | | |
808 | 808 | | |
| |||
835 | 835 | | |
836 | 836 | | |
837 | 837 | | |
838 | | - | |
839 | | - | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
840 | 841 | | |
841 | 842 | | |
842 | 843 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
| |||
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
| 91 | + | |
90 | 92 | | |
91 | 93 | | |
92 | 94 | | |
| |||
318 | 320 | | |
319 | 321 | | |
320 | 322 | | |
321 | | - | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
322 | 330 | | |
323 | 331 | | |
324 | 332 | | |
| |||
355 | 363 | | |
356 | 364 | | |
357 | 365 | | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
358 | 381 | | |
359 | 382 | | |
360 | 383 | | |
| |||
0 commit comments