Skip to content

Commit b71766e

Browse files
committed
test: tighten boundary fault evidence
1 parent ac84c64 commit b71766e

2 files changed

Lines changed: 33 additions & 4 deletions

File tree

‎src/__tests__/test-utils/boundary-fault-matrix.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,22 +123,22 @@ export const BOUNDARY_FAULT_MATRIX = {
123123
mutation: {
124124
kind: 'covered',
125125
evidence: ['src/daemon/client/__tests__/boundary-fault-acceptance.test.ts'],
126-
invariants: ['bounded-deadline', 'no-mutation-replay', 'typed-error-identity'],
126+
invariants: ['bounded-deadline', 'no-mutation-replay'],
127127
},
128128
read: {
129129
kind: 'covered',
130130
evidence: ['src/daemon/client/__tests__/boundary-fault-acceptance.test.ts'],
131-
invariants: ['bounded-deadline', 'typed-error-identity'],
131+
invariants: ['bounded-deadline'],
132132
},
133133
'artifact-producing': {
134134
kind: 'covered',
135135
evidence: ['src/daemon/client/__tests__/boundary-fault-acceptance.test.ts'],
136-
invariants: ['bounded-deadline', 'typed-error-identity'],
136+
invariants: ['bounded-deadline'],
137137
},
138138
'session-lifecycle': {
139139
kind: 'covered',
140140
evidence: ['src/daemon/client/__tests__/boundary-fault-acceptance.test.ts'],
141-
invariants: ['bounded-deadline', 'typed-error-identity'],
141+
invariants: ['bounded-deadline'],
142142
},
143143
},
144144
'lost-response-after-mutation': {

‎src/daemon/client/__tests__/boundary-fault-transport.test.ts‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,35 @@ test('socket partial response fails at end-of-stream instead of waiting for the
174174
assert.ok(Date.now() - startedAt < 500, 'EOF should reject before the injected deadline');
175175
});
176176

177+
test('socket empty response fails at end-of-stream with request context', async () => {
178+
const endpoint = await startNetServer((socket) => {
179+
socket.once('data', () => {
180+
socket.end();
181+
});
182+
});
183+
const request = buildRequest(COMMAND_ROWS.read, 'socket-empty');
184+
const startedAt = Date.now();
185+
186+
await assert.rejects(
187+
sendRequest(
188+
{ port: endpoint.port, token: 'test-token', pid: process.pid },
189+
request,
190+
'socket',
191+
daemonPaths(),
192+
1_000,
193+
),
194+
(error: unknown) => {
195+
assert.ok(error instanceof AppError);
196+
assert.equal(error.code, 'COMMAND_FAILED');
197+
assert.equal(error.message, 'Invalid daemon response');
198+
assert.equal(error.details?.requestId, request.meta?.requestId);
199+
return true;
200+
},
201+
);
202+
203+
assert.ok(Date.now() - startedAt < 500, 'EOF should reject before the injected deadline');
204+
});
205+
177206
test('socket malformed response stays typed at the daemon client seam', async () => {
178207
const endpoint = await startNetServer((socket) => {
179208
socket.once('data', () => {

0 commit comments

Comments
 (0)