You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b55d10a
Browse filesBrowse the repository at this point in the historyBrowse files
docs: name the failed-step kinds and the URL-owner exception once
The exception lived implied in two comments and contradicted the lookup case
they described. applyAttemptReport now owns the sentence: alert-read,
alert-accept and runner settle to the unknown state, while url-owner reports
the seen url-owner-unresolved. The settle doc and the test-table header point
at that rule instead of restating it.
Copy file name to clipboardExpand all lines: packages/platform-apple/src/open-policy.ts
+11-7Lines changed: 11 additions & 7 deletions
Original file line number
Diff line number
Diff line change
@@ -127,9 +127,10 @@ export function releaseSpeculativeRunner(
127
127
* visible after a failed accept also fails the open, even if the app is running. A missing prompt
128
128
* leaves the launch unchanged; an unrecognized prompt or an unresolved URL owner leaves it
129
129
* unchanged and reports `launchConfirmation: 'unanswered'` with its typed reason, because the
130
-
* prompt is on the screen the caller still has to answer. A probe step that failed or went unverified reports
131
-
* no confirmation and names itself, leaving the daemon to warn that the prompt state is unknown. An unresolved owner spends both the 3-second presentation window and the bounded
132
-
* URL-owner lookup.
130
+
* prompt is on the screen the caller still has to answer. A step that failed or went unverified
131
+
* settles to the unknown prompt state, which the daemon turns into a check-with-`alert get`
132
+
* warning; `applyAttemptReport` owns that reporting rule and its one lookup exception. An
133
+
* unresolved owner spends both the 3-second presentation window and the bounded URL-owner lookup.
133
134
*/
134
135
exportasyncfunctionsettleAppleOpen(
135
136
host: Pick<PlatformRuntimeHost,'clock'>,
@@ -296,10 +297,13 @@ function settleAttempt(attempt: LaunchConfirmationAttempt): AttemptSettlement {
296
297
297
298
/**
298
299
* The one rule mapping an answer attempt to what the settle reports. Every attempt states the
299
-
* latest the probe knows: a seen confirmation replaces the report, a step that failed or went unverified
300
-
* replaces it with the unknown state, and a completed probe that saw nothing resolves the unknown
301
-
* and keeps any confirmation already seen — an accepted is a completed action the caller owns. An
302
-
* `alert-still-present` attempt belongs to the failed-accept path, which fails the open outright.
300
+
* latest the probe knows: a seen confirmation replaces the report, a step that failed or went
301
+
* unverified (`alert-read`, `alert-accept` or `runner`) replaces it with the unknown state, and a
302
+
* completed probe that saw nothing resolves the unknown and keeps any confirmation already seen —
303
+
* an accepted is a completed action the caller owns. The one exception to the failed-step rule is
304
+
* `url-owner`: that lookup ran and answered nothing usable, so it reports the seen outcome
305
+
* `url-owner-unresolved`. An `alert-still-present` attempt belongs to the failed-accept path,
0 commit comments