You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b1cc79e
Browse filesBrowse the repository at this point in the historyBrowse files
fix(eager-closure): a tolerated split may only add new files; shrinkage cannot fund an eager edge
Maintainer review on #3298: the two-fact tolerance (containment + flat weight) never
checked WHERE the added modules came from, so a PR could statically import a heavy
merge-base module that sat outside the closure and pay for it by deleting top-level
statements elsewhere in the same closure. Both facts still held; real growth passed.
The tolerance is now three facts, all read from the graphs plus the merge-base tree:
containment, added-module NOVELTY (every head-closure module the base closure did not
evaluate is absent from the merge-base tree at its rename-canonicalized path -- checked
at the BASE path for a rename's head, so re-naming a closure-external module into the
closure is still pre-existing code newly made eager), and flat weight. classifyGrowth
requires all three and prints one reason per failed fact.
Planted, in the maintainer's exact shape: the split fixture plus a committed
pre-existing-heavy.ts pulled in by part-c, weight offset by merging the hub's two
remaining declarations -- containment holds, weight flat 3->3, novelty false, verdict
names shrinkage-funding. Unit-level pair for the fact itself, and rename-canonicalized
novelty pinned with and without the rename map against a colliding tree. Mutation:
dropping the novelty conjunct fails exactly the two planted novelty tests and nothing
else.
ADR 0027 (status, rules, decision, alternatives: the first draft is now a named refuted
alternative) and ADR 0028 step 3 state the three facts; the residue paragraph drops the
'true of any closure' claim.
Copy file name to clipboardExpand all lines: docs/adr/README.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -28,7 +28,7 @@
28
28
|[0024 Screen Recording — One Coordinator, Two Facts (Proposed)](0024-screen-recording-provable-signal.md)|`record start`/`stop` lifecycle, the export-exists / recorder-stopped split, backend stop-and-collect contract, recovery through the coordinator, the ADR 0019 §5 amendment and the failed-finish cleanup fix |
29
29
|[0025 Foldable Apple Panels — Capture the Lit Panel](0025-foldable-apple-panels.md)| iPhone Duo outer/inner panels, CoreDevice display info as the only screen authority, why `simctl`'s implicit display default captures a black panel, derived (never asserted) pose, and why no pose-control command exists |
30
30
|[0026 Scroll Clip Authority — Ownership Is the Parent Edge](0026-scroll-clip-authority.md)| iOS scroll indicators and the visible band, why ownership is read from the parent edge instead of an ancestor walk, what may remove a node from an interactive snapshot, and ejection dispositions |
31
-
|[0027 Descriptor Root Size vs Eager-Closure Budget](0027-descriptor-root-vs-eager-closure-budget.md)| accepted: the eager-closure budget tolerates a statement-neutral hub split (containment + flat top-level-statement weight) and nothing else; splitting `packages/command-registry/src/registry.ts` is unblocked |
31
+
|[0027 Descriptor Root Size vs Eager-Closure Budget](0027-descriptor-root-vs-eager-closure-budget.md)| accepted: the eager-closure budget tolerates a statement-neutral hub split only (containment + added-module novelty + flat top-level-statement weight) and nothing else; splitting `packages/command-registry/src/registry.ts` is unblocked |
32
32
|[0028 Capability-Family Cell Vocabulary — One Runtime Source (Proposed)](0028-capability-family-cell-vocabulary.md)| adding a capability operation family, `UnavailablePlatformRuntimeFacts` / `UNAVAILABLE_CELLS`, `INTERACTOR_OPERATIONS`, and why an eight-package fan-out recurs |
33
33
|[0029 Daemon Policy](0029-daemon-policy.md)|`AGENT_DEVICE_DAEMON_POLICY`, confining a daemon's commands, devices, or device shutdown, and where operator rules are enforced for batch/replay steps |
34
34
|[0030 Process Lock Exclusion](0030-process-lock-exclusion.md)| process-lock publication/reclaim/release, retained mutation guards, and the single-protocol upgrade boundary |
0 commit comments