Repository navigation
Commit afafe1a
committed
fix(runner): bound XCTest's idle wait around alert activation
An alert button is read as hittable before it is tapped, so XCTest's own wait for the app to
idle before synthesizing that tap adds nothing the runner has not already checked. Its default
outlives the command, so the tap lands after the caller was told the alert timed out (#2546).
The helper that bounds that wait was named for the scroll path that owned it; gesture, type and
swipe already went through it, and alert activation now does too, so it is named for the wait it
bounds. Each caller states which of XCTest's two waits it gives up: the gesture, type and swipe
paths skip both, because their next step is a poll of their own, while alert activation drops only
the pre-event wait. Its verification reads the alert this tap replaced, and an alert that dismisses
in order to present an identical replacement passes through a moment with no alert at all — a first
read landing in that moment reported a dismissal nothing had proved.1 parent 2cafab3 commit afafe1a
4 files changed
Lines changed: 52 additions & 9 deletions
File tree
- apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
72 | 81 | | |
73 | 82 | | |
74 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
101 | 103 | | |
102 | 104 | | |
103 | 105 | | |
| |||
2075 | 2077 | | |
2076 | 2078 | | |
2077 | 2079 | | |
2078 | | - | |
| 2080 | + | |
2079 | 2081 | | |
2080 | 2082 | | |
2081 | 2083 | | |
| |||
2087 | 2089 | | |
2088 | 2090 | | |
2089 | 2091 | | |
2090 | | - | |
| 2092 | + | |
2091 | 2093 | | |
2092 | 2094 | | |
2093 | 2095 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
24 | 42 | | |
25 | 43 | | |
26 | 44 | | |
| |||
209 | 227 | | |
210 | 228 | | |
211 | 229 | | |
212 | | - | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
213 | 236 | | |
| 237 | + | |
214 | 238 | | |
215 | 239 | | |
216 | 240 | | |
| |||
219 | 243 | | |
220 | 244 | | |
221 | 245 | | |
222 | | - | |
| 246 | + | |
223 | 247 | | |
224 | 248 | | |
225 | 249 | | |
226 | 250 | | |
227 | 251 | | |
228 | 252 | | |
229 | | - | |
| 253 | + | |
230 | 254 | | |
231 | 255 | | |
232 | 256 | | |
233 | 257 | | |
234 | 258 | | |
| 259 | + | |
235 | 260 | | |
236 | 261 | | |
237 | 262 | | |
| |||
252 | 277 | | |
253 | 278 | | |
254 | 279 | | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
255 | 287 | | |
256 | 288 | | |
257 | 289 | | |
258 | 290 | | |
259 | 291 | | |
260 | | - | |
| 292 | + | |
261 | 293 | | |
262 | 294 | | |
263 | 295 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
0 commit comments