@@ -18,6 +18,8 @@ const state = vi.hoisted(() => ({
1818 /** Instance deletes this runtime asked Limrun for; each waits for its case to answer it. */
1919 deletes : [ ] as Array < { instanceId : string ; report : ( ) => void } > ,
2020 creates : 0 ,
21+ clientStarts : 0 ,
22+ clientGate : undefined as Promise < void > | undefined ,
2123 createGate : undefined as Promise < void > | undefined ,
2224 autoDelete : false ,
2325 disconnects : 0 ,
@@ -62,31 +64,35 @@ vi.mock('@limrun/api', () => ({
6264} ) ) ;
6365
6466vi . mock ( '@limrun/api/instance-client' , ( ) => ( {
65- createInstanceClient : vi . fn ( async ( ) => ( {
66- disconnect : ( ) => {
67- state . disconnects += 1 ;
68- if ( state . disconnectThrows ) throw new Error ( 'instance client refused to disconnect' ) ;
69- } ,
70- keepAlive : ( ) => { } ,
71- openUrl : vi . fn ( ) ,
72- sendAsset : vi . fn ( ) ,
73- pressKey : vi . fn ( ) ,
74- setText : vi . fn ( ) ,
75- tap : vi . fn ( ) ,
76- startAdbTunnel : vi . fn ( async ( ) => ( {
77- address : { address : '127.0.0.1' , port : 62001 } ,
78- close : ( ) => { } ,
79- } ) ) ,
80- startTunnel : vi . fn ( async ( ) => ( {
81- tunnelId : 't1' ,
82- selectors : [ ] ,
83- close : ( ) => {
84- state . captureCloses += 1 ;
85- if ( state . captureCloseThrows ) throw new Error ( 'capture tunnel refused to close' ) ;
67+ createInstanceClient : vi . fn ( async ( ) => {
68+ state . clientStarts += 1 ;
69+ await state . clientGate ;
70+ return {
71+ disconnect : ( ) => {
72+ state . disconnects += 1 ;
73+ if ( state . disconnectThrows ) throw new Error ( 'instance client refused to disconnect' ) ;
8674 } ,
87- } ) ) ,
88- getTunnelStatus : vi . fn ( async ( ) => ( { } ) ) ,
89- } ) ) ,
75+ keepAlive : ( ) => { } ,
76+ openUrl : vi . fn ( ) ,
77+ sendAsset : vi . fn ( ) ,
78+ pressKey : vi . fn ( ) ,
79+ setText : vi . fn ( ) ,
80+ tap : vi . fn ( ) ,
81+ startAdbTunnel : vi . fn ( async ( ) => ( {
82+ address : { address : '127.0.0.1' , port : 62001 } ,
83+ close : ( ) => { } ,
84+ } ) ) ,
85+ startTunnel : vi . fn ( async ( ) => ( {
86+ tunnelId : 't1' ,
87+ selectors : [ ] ,
88+ close : ( ) => {
89+ state . captureCloses += 1 ;
90+ if ( state . captureCloseThrows ) throw new Error ( 'capture tunnel refused to close' ) ;
91+ } ,
92+ } ) ) ,
93+ getTunnelStatus : vi . fn ( async ( ) => ( { } ) ) ,
94+ } ;
95+ } ) ,
9096} ) ) ;
9197
9298test ( 'a local teardown that refuses beside a pending delete is reported, not loosed on the process' , async ( ) => {
@@ -219,6 +225,7 @@ test('a capture close that refuses still leaves the delete it ran beside answere
219225
220226test ( 'a late create with failed local cleanup is freed by the normal take with confirmed deletion' , async ( ) => {
221227 await import ( './lease-release.ts' ) ;
228+ const rejections = watchUnhandledRejections ( ) ;
222229 const createsBefore = state . creates ;
223230 state . deletes . length = 0 ;
224231 state . disconnectThrows = true ;
@@ -275,6 +282,8 @@ test('a late create with failed local cleanup is freed by the normal take with c
275282 state . createGate = undefined ;
276283 await runtime . leaseLifecycle . allocate ?.( lease ) ;
277284 expect ( state . creates - createsBefore ) . toBe ( 2 ) ;
285+ vi . useRealTimers ( ) ;
286+ await rejections . assertIsSilent ( ) ;
278287 } finally {
279288 reportCreate ( ) ;
280289 state . createGate = undefined ;
@@ -285,6 +294,59 @@ test('a late create with failed local cleanup is freed by the normal take with c
285294 await runtime . shutdown ( ) ;
286295 state . autoDelete = false ;
287296 state . deletes . length = 0 ;
297+ rejections . stop ( ) ;
298+ }
299+ } ) ;
300+
301+ test ( 'a confirmed delete during creation still disconnects the late session without another rent' , async ( ) => {
302+ await import ( './lease-release.ts' ) ;
303+ const rejections = watchUnhandledRejections ( ) ;
304+ const createsBefore = state . creates ;
305+ const clientsBefore = state . clientStarts ;
306+ const disconnectsBefore = state . disconnects ;
307+ state . deletes . length = 0 ;
308+ let reportClient ! : ( ) => void ;
309+ state . clientGate = new Promise < void > ( ( resolve ) => {
310+ reportClient = resolve ;
311+ } ) ;
312+ const runtime = createLimrunRuntime ( { apiKey : 'lim_test_key' } , testDependencies ( ) ) ;
313+ const lease = androidLease ( 'lease-confirmed-before-session' ) ;
314+ const allocating = Promise . resolve ( runtime . leaseLifecycle . allocate ?.( lease ) ) . catch (
315+ ( error : unknown ) => error ,
316+ ) ;
317+ try {
318+ // Reaching the instance client means the one POST has already named the rented instance.
319+ await vi . waitFor ( ( ) => expect ( state . clientStarts - clientsBefore ) . toBe ( 1 ) ) ;
320+ const released = runtime . leaseLifecycle . release ?.( lease ) ;
321+ vi . useFakeTimers ( ) ;
322+ await vi . advanceTimersByTimeAsync ( 125_000 ) ;
323+ expect ( state . deletes ) . toHaveLength ( 1 ) ;
324+ state . deletes [ 0 ] ?. report ( ) ;
325+ await vi . advanceTimersByTimeAsync ( 50_000 ) ;
326+ expect ( await released ) . toMatchObject ( {
327+ limrunInstanceId : 'android-instance-1' ,
328+ warnings : [ { code : 'LIMRUN_TEARDOWN_INCOMPLETE' } ] ,
329+ } ) ;
330+ expect ( state . disconnects - disconnectsBefore ) . toBe ( 0 ) ;
331+ // The owner has been closed, but its observed, memoized local release still owns this session.
332+ reportClient ( ) ;
333+ await vi . advanceTimersByTimeAsync ( 0 ) ;
334+ expect ( await allocating ) . toMatchObject ( {
335+ details : { reason : 'limrun_lease_released_mid_allocation' } ,
336+ } ) ;
337+ expect ( state . creates - createsBefore ) . toBe ( 1 ) ;
338+ expect ( state . deletes ) . toHaveLength ( 1 ) ;
339+ expect ( state . disconnects - disconnectsBefore ) . toBe ( 1 ) ;
340+ vi . useRealTimers ( ) ;
341+ await rejections . assertIsSilent ( ) ;
342+ } finally {
343+ reportClient ( ) ;
344+ state . clientGate = undefined ;
345+ state . deletes . forEach ( ( { report } ) => report ( ) ) ;
346+ vi . useRealTimers ( ) ;
347+ await runtime . shutdown ( ) ;
348+ state . deletes . length = 0 ;
349+ rejections . stop ( ) ;
288350 }
289351} ) ;
290352
0 commit comments