Repository navigation
Commit a9018d1
committed
revert(daemon): keep the liveness probe's HTTP leg standalone
Reverts the health-read reuse from c71b306. Both ways of breaking the static
cycle the reuse creates fail a gate:
- Fallow caught the cycle itself: `readDaemonHttpHealth` lives in the
transport, the transport imports the timeout handler, and the timeout
handler loads the probe on demand, so the probe importing the transport is
transport -> timeout -> probe -> transport.
- The two hosts that break it cost more than the ~25 lines they save. A new
module adds one to the CLI's eager closure (295 -> 296), which the ADR 0019
loading-shape gate refuses; the only already-eager host is the wire-codec
module, and hosting a /health reader there splits this PR across six of the
ADR 0006 health declarations, digests and acks included.
The probe's leg therefore builds its own /health GET again: it needs an
absolute 1s budget and a cancel handle, where the reachability reader wants a
500ms cap and a reachability verdict. A new test pins the difference, because
reading `reachable` in the probe would make a daemon answering 5xx look
silent and authorize the kill #3177 is about.
Keeps the parts of c71b306 that stand on their own: the comment trims from the
same review, and the probe header's over-claim corrected — the idle-timeout
argument holds for the socket leg, not for the HTTP reader's own cap.1 parent a1ae1cf commit a9018d1
4 files changed
Lines changed: 41 additions & 47 deletions
File tree
- src/daemon-client
- __tests__
- test/wire-compat
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
82 | | - | |
83 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
18 | 17 | | |
19 | 18 | | |
20 | 19 | | |
21 | | - | |
22 | | - | |
23 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
24 | 23 | | |
25 | 24 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
31 | 30 | | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
38 | | - | |
| 37 | + | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| |||
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
88 | | - | |
| 87 | + | |
89 | 88 | | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
94 | 92 | | |
95 | 93 | | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
104 | 108 | | |
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
108 | | - | |
109 | 112 | | |
110 | 113 | | |
111 | 114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | 147 | | |
155 | 148 | | |
156 | 149 | | |
| |||
160 | 153 | | |
161 | 154 | | |
162 | 155 | | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
170 | 160 | | |
171 | | - | |
| 161 | + | |
172 | 162 | | |
173 | 163 | | |
174 | 164 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
431 | 431 | | |
432 | 432 | | |
433 | 433 | | |
434 | | - | |
435 | | - | |
| 434 | + | |
| 435 | + | |
436 | 436 | | |
437 | 437 | | |
438 | 438 | | |
0 commit comments