Skip to content

Commit a3e9675

Browse files
thymikeethymikee
authored
refactor: rename ios-runner -> apple-runner (#981) (#996)
Finish the cosmetic ios-runner -> apple-runner rename now that the top-level XCTest runner is the OS-agnostic Apple engine (iOS/iPadOS/tvOS/macOS/visionOS from one Xcode project). Cosmetic only, no behavior change: - git mv ios-runner/ -> apple-runner/ (AgentDeviceRunner, README, RUNNER_PROTOCOL) - Update repo project-path consumers: build-xcuitest-apple.sh, package.json files globs, .fallowrc.json, write-xcuitest-cache-metadata.mjs, runner-xctestrun.ts fingerprint/project paths, recording overlay + test, daemon-client-timeout kill pattern, setup-apple-replay hashFiles glob, ci.yml swift-compat scan, AGENTS.md. - Rename runtime home cache/derived/lease dir default ~/.agent-device/ios-runner -> ~/.agent-device/apple-runner (build script, package/clean scripts, runner-xctestrun RUNNER_DERIVED_ROOT, runner-lease, runner-contract hint, cli-help/commands.md docs) and the tests asserting it. - Rename OS-agnostic runner symbols: runIosRunnerCommand -> runAppleRunnerCommand, prewarmIosRunnerCache -> prewarmAppleRunnerCache, createIosRunnerCachePrewarmOnColdBoot / createIosRunnerCacheColdBootPrewarmForOpen -> createAppleRunner* (+ call sites, type aliases, test mocks). Intentionally left as ios-runner (out of scope / would change behavior): - prepare ios-runner CLI subcommand (user-facing command name) - AGENT_DEVICE_IOS_RUNNER_* env var names and .tmp/ios-runner-derived CI values - ios-runner-prebuilt cache-key-prefix, ci.yml job id, workflow/ADR filenames - agent-device-ios-runner-<version> release artifact basenames Part of #972 (Phase 3 - Apple PlatformPlugin).
1 parent d21b8ce commit a3e9675

84 files changed

Lines changed: 283 additions & 275 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.fallowrc.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"examples/test-app/**",
2929
"scripts/perf/**",
3030
"scripts/layering/**",
31-
"ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests.xctestplan",
31+
"apple-runner/AgentDeviceRunner/AgentDeviceRunnerUITests.xctestplan",
3232
"scripts/write-xcuitest-cache-metadata.mjs"
3333
],
3434
"ignoreDependencies": ["@microsoft/api-extractor", "@theme"],

‎.github/actions/setup-apple-replay/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ runs:
5252
id: source-hash
5353
run: |
5454
set -euo pipefail
55-
echo "value=${{ hashFiles('ios-runner/**', 'scripts/build-xcuitest-apple.sh', 'scripts/patch-xcuitest-runner-icon.ts', 'scripts/write-xcuitest-cache-metadata.mjs', 'src/platforms/ios/apple-runner-platform.ts', 'src/platforms/ios/runner-icon.ts', 'src/platforms/ios/runner-xctestrun.ts', 'src/platforms/ios/runner-xctestrun-products.ts', '.github/actions/setup-apple-replay/action.yml', 'package.json', 'pnpm-lock.yaml') }}" >> "$GITHUB_OUTPUT"
55+
echo "value=${{ hashFiles('apple-runner/**', 'scripts/build-xcuitest-apple.sh', 'scripts/patch-xcuitest-runner-icon.ts', 'scripts/write-xcuitest-cache-metadata.mjs', 'src/platforms/ios/apple-runner-platform.ts', 'src/platforms/ios/runner-icon.ts', 'src/platforms/ios/runner-xctestrun.ts', 'src/platforms/ios/runner-xctestrun-products.ts', '.github/actions/setup-apple-replay/action.yml', 'package.json', 'pnpm-lock.yaml') }}" >> "$GITHUB_OUTPUT"
5656
shell: bash
5757

5858
- name: Cache replay prebuilt

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232

3333
- name: Disallow trailing commas before closing parenthesis in Swift
3434
run: |
35-
if rg -nU --glob '*.swift' ',\s*\n\s*\)' ios-runner; then
35+
if rg -nU --glob '*.swift' ',\s*\n\s*\)' apple-runner; then
3636
echo "Found trailing commas before ')' in Swift files. This syntax requires Swift 6.1+ and breaks older Xcode toolchains."
3737
exit 1
3838
fi

‎AGENTS.md‎

Lines changed: 1 addition & 1 deletion

ios-runner/AgentDeviceRunner/AgentDeviceRunner.xcodeproj/project.pbxproj renamed to apple-runner/AgentDeviceRunner/AgentDeviceRunner.xcodeproj/project.pbxproj

File renamed without changes.

ios-runner/AgentDeviceRunner/AgentDeviceRunner.xcodeproj/project.xcworkspace/contents.xcworkspacedata renamed to apple-runner/AgentDeviceRunner/AgentDeviceRunner.xcodeproj/project.xcworkspace/contents.xcworkspacedata

File renamed without changes.

ios-runner/AgentDeviceRunner/AgentDeviceRunner.xcodeproj/xcshareddata/xcschemes/AgentDeviceRunner.xcscheme renamed to apple-runner/AgentDeviceRunner/AgentDeviceRunner.xcodeproj/xcshareddata/xcschemes/AgentDeviceRunner.xcscheme

File renamed without changes.

ios-runner/AgentDeviceRunner/AgentDeviceRunner/AgentDeviceRunnerApp.m renamed to apple-runner/AgentDeviceRunner/AgentDeviceRunner/AgentDeviceRunnerApp.m

File renamed without changes.

ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests.xctestplan renamed to apple-runner/AgentDeviceRunner/AgentDeviceRunnerUITests.xctestplan

File renamed without changes.

ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/AgentDeviceRunnerUITests-Bridging-Header.h renamed to apple-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/AgentDeviceRunnerUITests-Bridging-Header.h

File renamed without changes.

0 commit comments

Comments
 (0)