Skip to content

Commit a1c38d5

Browse files
committed
refactor(daemon): apply one dispatch-disclosure rule to returned and thrown failures
1 parent b4d9a73 commit a1c38d5

1 file changed

Lines changed: 4 additions & 9 deletions

File tree

‎src/daemon/request-dispatch-disclosure.ts‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ import {
33
asAppError,
44
detailsAfterDispatchedSteps,
55
discloseDispatch,
6-
discloseDispatchAfterSteps,
7-
discloseUnclassifiedDispatch,
86
type ErrorWireDetails,
97
} from '@agent-device/kernel/errors';
108
import { resolveCommandRecordingEffect } from '@agent-device/command-registry/registry';
@@ -35,13 +33,10 @@ export async function discloseRequestDispatch<Response extends DaemonResponse |
3533
return { ...response, error: { ...response.error, details } };
3634
} catch (error) {
3735
const failure = asAppError(error);
38-
if (ledger.dispatchedSteps > 0) {
39-
discloseDispatchAfterSteps(failure, ledger.dispatchedSteps);
40-
throw failure;
41-
}
42-
if (effect === undefined) throw error;
43-
if (effect === 'observes-app') throw discloseDispatch(failure, 'no');
44-
throw discloseUnclassifiedDispatch(failure, 'unknown');
36+
const details = disclosedDetails(effect, failure.details, ledger);
37+
if (details === failure.details) throw error;
38+
failure.details = details;
39+
throw failure;
4540
}
4641
}
4742

0 commit comments

Comments
 (0)