You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a1ae1cf
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(daemon): ride the owned health read for the liveness probe's HTTP leg
Review at 7d78066 (non-blocking): `probeHttpHealth` repeated the /health GET
that `readDaemonHttpHealth` already owns. The health read now takes the
caller's abort signal and an opt-out from its reachability timeout caps, and
the probe's HTTP leg is a call to it: the socket leg and the concurrent race
stay, because a TCP connect alone cannot show a blocked event loop answers.
One verdict nuance the reuse makes visible: the reachability reader reports a
5xx as unreachable, while the probe asks only whether the endpoint answered, so
the leg counts any status code. Reading `reachable` there would make a daemon
answering 500 look silent and authorize the kill #3177 is about; a test pins
the difference.
Also folds the reviewer's comment trims (probe header, loopback teardown,
timeout reset block) and refreshes the wire ledger's compatible-change ack for
the client-local signature change: the request line, method, headers and
accepted payload fields a released peer sees are unchanged.
"rationale": "A restart retry must tell a probe that ran out of time from one that failed, so the client can report the RPC deadline instead of 'Remote daemon is unavailable'. `timedOut` is client-local: the prober sets it on its own timeout and abort paths and never reads it from a /health payload. The health request and the accepted payload fields are unchanged, so a released daemon or proxy is probed and parsed exactly as before."
"rationale": "The post-timeout liveness probe (#3177) reuses this health read as its HTTP leg, so the budget and abort signal became caller-supplied options instead of an internal AbortSignal.timeout. Both are client-local: the /health request line, method, headers and accepted payload fields a released daemon or proxy sees are unchanged, and the health-check timeout caps still apply to every reachability probe that does not opt out."
0 commit comments