Skip to content

Commit 9f1ba11

Browse files
committed
docs(adr): correct the idle sweep scope and recording overlay coverage
The idle sweep and lease session end run in the daemon-level diagnostics scope. recording-overlay.test.ts also covers Android emulator cases behind the same AGENT_DEVICE_RECORDING_E2E switch. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016qAu53rMak1bXMuR5U2gF4
1 parent 1a4a1aa commit 9f1ba11

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎docs/adr/0018-unified-event-journal.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
Partly accepted.
66
The session event log contract is accepted and implemented in `packages/session-journal/src`: `events.ndjson` v1 entries, size-capped rotation to one retained generation, the verifying retention-window sidecar, and the typed `EVENT_LOG_CURSOR_EXPIRED` and `EVENT_LOG_WINDOW_UNVERIFIED` cursor errors of the `events` command.
7-
Out-of-request work, such as the idle sweep, runs in a session-scoped diagnostics scope.
7+
Out-of-request work, such as the idle sweep and lease session end, runs in the daemon-level diagnostics scope (`session: 'daemon'`), not in a per-session teardown scope.
88
The rest of this record remains proposed (2026-07-24) and is not implemented: the event catalog, the single journal append point, registered sinks, forked scopes with parent scope identity, and the usage record.
99
The proposed names below (`EVENT_CATALOG`, `EventKind`, `UsageRecord`, `parentScopeId`) do not exist in code.
1010
The [pre-slimming text](https://github.com/callstack/agent-device/blob/e35d0d496fb820d57d95fcad1b6b62dfa9962abb/docs/adr/0018-unified-event-journal.md) is historical context only: its inventory and step order are not current guidance.

‎docs/adr/0025-foldable-apple-panels.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -507,8 +507,8 @@ The same synthetic captures now match `--hide-touches`:
507507

508508
The `after` column comes from this host's offline synthetic harness.
509509
It reproduces the failure and confirms preserved geometry after the fix.
510-
`test/integration/recording-overlay.test.ts` covers only the default iOS simulator.
511-
`AGENT_DEVICE_RECORDING_E2E` enables that case, and no CI lane sets it.
510+
`test/integration/recording-overlay.test.ts` covers the default iOS simulator and Android emulator cases, not a non-rot90 target or a Duo inner panel.
511+
`AGENT_DEVICE_RECORDING_E2E` gates all of these cases, and no CI lane sets it.
512512
On-device completion measurements for a non-rot90 target and a Duo inner panel are an open gap.
513513
The test compares touched export with a `--hide-touches` control.
514514
It asserts equal track size and verifies that the overlay drew touches.

0 commit comments

Comments
 (0)