Repository navigation
Commit 9ef0088
committed
fix(ios): make the placeholder attribute optional in the bridge vocabulary, read it on text entry only
Review follow-ups. The Simulator AX bridge asked for the placeholder attribute
in its required set, so a runtime whose vocabulary lacks it would have failed
every capture; a mismatch now retries the mapping without the attribute and the
capture serves without placeholders. The bridge trims the placeholder the way
the runner does, so whitespace reads as none. The element sweeps read a live
XCUIElement attribute per element inside their deadline, so they read
placeholderValue on text-entry types only; the snapshot producer keeps reading
it off the snapshot it already holds.1 parent fd3ae05 commit 9ef0088
4 files changed
Lines changed: 30 additions & 5 deletions
File tree
- apple
- runner/AgentDeviceRunner/AgentDeviceRunnerUITests
- snapshot-bridge
- packages/platform-apple/src/snapshot-source
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
248 | 260 | | |
249 | 261 | | |
250 | 262 | | |
| |||
387 | 399 | | |
388 | 400 | | |
389 | 401 | | |
390 | | - | |
| 402 | + | |
391 | 403 | | |
392 | 404 | | |
393 | 405 | | |
| |||
571 | 583 | | |
572 | 584 | | |
573 | 585 | | |
574 | | - | |
| 586 | + | |
575 | 587 | | |
576 | 588 | | |
577 | 589 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
342 | 350 | | |
343 | 351 | | |
344 | 352 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
483 | 483 | | |
484 | 484 | | |
485 | 485 | | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
486 | 491 | | |
487 | 492 | | |
488 | 493 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
| 251 | + | |
| 252 | + | |
251 | 253 | | |
252 | 254 | | |
253 | 255 | | |
| |||
262 | 264 | | |
263 | 265 | | |
264 | 266 | | |
265 | | - | |
266 | | - | |
267 | | - | |
| 267 | + | |
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
| |||
0 commit comments