Skip to content

Commit 9e660b7

Browse files
committed
refactor(android): check Compose role containment with rectContains
1 parent 557ee41 commit 9e660b7

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

‎packages/platform-android/src/ui-hierarchy-compose-role.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { intersectArea } from '@agent-device/kernel/screenshot-geometry';
1+
import { isPositiveFiniteRect, rectContains } from '@agent-device/kernel/rect';
22
import type { Rect } from '@agent-device/kernel/snapshot';
33
import type { AndroidSnapshotPresentationBudget } from './snapshot-presentation.ts';
44
import { isAgentTarget, type AndroidNode, type AndroidUiHierarchy } from './ui-hierarchy-node.ts';
@@ -52,6 +52,5 @@ function isComposeRoleNode(child: AndroidNode, parent: AndroidNode): boolean {
5252
}
5353

5454
function liesInside(inner: Rect | undefined, outer: Rect | undefined): boolean {
55-
if (!inner || !outer || inner.width <= 0 || inner.height <= 0) return false;
56-
return intersectArea(inner, outer) === inner.width * inner.height;
55+
return isPositiveFiniteRect(inner) && outer !== undefined && rectContains(outer, inner);
5756
}

0 commit comments

Comments
 (0)