Repository navigation
Commit 9d6012c
authored
* fix(ios): stop a fill's post-focus reads from recording an XCTest failure (#3238)
#3237 settled this on the tap route; the type/fill focus path kept two reads of
the element it resolved BEFORE its own focus tap. `textEntryRefreshPoint(for:)`
read `element.frame` after that tap to build the target's refresh point, and
`moveCaretToEnd(element:)` read it before the caret edge-tap reached from
`clearTextInput` on a replacement fill. A field that stops answering the query
that resolved it once it takes focus — the #3060 Flutter shape — turns either
read into a recorded "No matches found for …", which the dispatch path converts
into XCTEST_RECORDED_FAILURE plus an invalidated target for a focus the gesture
had already delivered. The report's `fill @e6` row measured 4.5 s at this seam.
Both frames now come from `textEntrySnapshotFrame`, which reads through
`snapshot()` — the throwing channel that records nothing, already how
`probeTextEntryInput` and `withElement` reach an element. Where the frame
cannot be answered the call sites degrade per the route's own rules: the
refresh point drops to NO point rather than the pre-focus one, because this
route's first resolve is not yet bound to an identity and a field that went
unqueryable on focus may have moved the layout so the old point names another
input, so the fill fails closed with a typed reason instead of typing into
that input; the caret edge-tap skips to the caller's point-free delete burst
rather than dispatching a point from a frame the field may have moved.
Runner-only, no CLI/daemon/API change. Reads that distinguish absence from
failure stay on `probeTextEntryInput`. A fill whose field genuinely did not
take focus still fails typed, and a genuinely recorded failure still
invalidates and surfaces. The regression test drives `fill` through
`execute(command:)` on the unqueryable-on-focus fixture: red before the change
at the refresh-point read, green after with the app-side focus witness proving
the gesture landed.
* fix(ios): dispatch the caret edge-tap app-relative instead of through the handle (#3329 review)
A successful `snapshot()` proves the handle answered its query when the frame was
read, not that it still answers when the tap dispatches — and an element-anchored
`coordinate(withNormalizedOffset:).tap()` re-runs the resolving query to place its
anchor when the action executes, the same #3060 recorder one call later. Both
branches now leave the handle: the edge-tap point is computed from the snapshot
frame and dispatched through `tapAt`, the app-relative coordinate route that
resolves no element at all — the shape `waitForTextEntryReadinessAfterTap`
settled on in #3237 — and the empty-frame `element.tap()` (how a departed handle
reads) is folded into the same fail-closed guard, degrading to the point-free
delete burst rather than tapping a handle that may not resolve. `clearTextInput`
threads `app` to reach `tapAt`; its three call sites already hold it.
No CLI/daemon/API change.
1 parent 5511ada commit 9d6012c
4 files changed
Lines changed: 111 additions & 18 deletions
File tree
- apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests
- UnitTests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
246 | | - | |
| 246 | + | |
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
| |||
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
260 | | - | |
| 260 | + | |
261 | 261 | | |
262 | 262 | | |
263 | 263 | | |
| |||
357 | 357 | | |
358 | 358 | | |
359 | 359 | | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
360 | 375 | | |
361 | 376 | | |
362 | 377 | | |
| |||
395 | 410 | | |
396 | 411 | | |
397 | 412 | | |
398 | | - | |
| 413 | + | |
399 | 414 | | |
400 | 415 | | |
401 | 416 | | |
402 | | - | |
403 | | - | |
404 | | - | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
405 | 429 | | |
406 | 430 | | |
407 | | - | |
408 | | - | |
409 | | - | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
410 | 435 | | |
411 | | - | |
412 | 436 | | |
413 | 437 | | |
414 | 438 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
| 140 | + | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
| |||
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
160 | | - | |
| 160 | + | |
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
166 | 178 | | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
167 | 182 | | |
168 | 183 | | |
169 | | - | |
170 | 184 | | |
171 | | - | |
| 185 | + | |
172 | 186 | | |
173 | 187 | | |
174 | 188 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| |||
465 | 465 | | |
466 | 466 | | |
467 | 467 | | |
468 | | - | |
| 468 | + | |
469 | 469 | | |
470 | 470 | | |
471 | 471 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
217 | 272 | | |
218 | 273 | | |
219 | 274 | | |
0 commit comments