Skip to content

Commit 97aac18

Browse files
thymikeeclaude
andcommitted
refactor(daemon-client): require the sent flag on transport failures
handleTransportError took daemonRequestSent through an optional details bag, so a producer that forgot it was read as sent only by convention. It is now a required boolean, as it already is for the timeout errors, so every producer of a transport failure states whether the request left. A missing flag still reads as sent, the conservative verdict. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 4ce87a2 commit 97aac18

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

‎packages/daemon-client/src/daemon-client-transport.ts‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -608,11 +608,15 @@ function requireDaemonTransport(
608608
throw daemonEndpointUnavailableError(transport);
609609
}
610610

611+
/**
612+
* `daemonRequestSent` is required: the client discloses dispatch from it, and a producer that
613+
* could not say would otherwise be read as sent.
614+
*/
611615
function handleTransportError(
612616
err: unknown,
613617
requestId: string | undefined,
614618
remote: boolean,
615-
details: Record<string, unknown> = {},
619+
daemonRequestSent: boolean,
616620
): AppError {
617621
emitDiagnostic({
618622
level: 'error',
@@ -626,7 +630,7 @@ function handleTransportError(
626630
'COMMAND_FAILED',
627631
'Failed to communicate with daemon',
628632
{
629-
...details,
633+
daemonRequestSent,
630634
reason: 'daemon_transport_failure',
631635
requestId,
632636
hint: remote
@@ -715,11 +719,7 @@ async function sendSocketRequest(
715719
settled = true;
716720
if (timeoutHandle) clearTimeout(timeoutHandle);
717721
detachCallerAbort();
718-
reject(
719-
handleTransportError(err, req.meta?.requestId, false, {
720-
daemonRequestSent: requestWritten,
721-
}),
722-
);
722+
reject(handleTransportError(err, req.meta?.requestId, false, requestWritten));
723723
});
724724
});
725725
}
@@ -917,9 +917,7 @@ async function sendHttpRequest(
917917
// from emitting a `daemon_request_socket_error` diagnostic; a genuine transport error still
918918
// arrives before the settle and rejects.
919919
if (settled) return;
920-
rejectOnce(
921-
handleTransportError(err, req.meta?.requestId, remote, { daemonRequestSent: requestSent }),
922-
);
920+
rejectOnce(handleTransportError(err, req.meta?.requestId, remote, requestSent));
923921
});
924922

925923
request.on('finish', () => {

0 commit comments

Comments
 (0)