Skip to content

Commit 929cdfc

Browse files
committed
chore(gates): run the macOS helper Swift tests with the macos-helper gate
The macos-helper gate only built the helper, so the new AgentDeviceMacOSInput schedule had no gate behind it. Add test:macos-helper and point the gate at check:macos-helper, which builds and tests, keeping the CI step id unchanged.
1 parent 946c71e commit 929cdfc

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

‎package.json‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@
107107
"package:android-ime-helper:npm": "rm -rf android/ime-helper/dist && AGENT_DEVICE_ANDROID_HELPER=ime sh ./scripts/package-android-helper.sh $(node -p \"require('./package.json').version\") android/ime-helper/dist",
108108
"build:macos-helper": "node --experimental-strip-types scripts/swift-toolchain-tmpdir.ts swift build -c release --package-path apple/macos-helper",
109109
"build:macos-helper:clean": "node --experimental-strip-types scripts/swift-toolchain-tmpdir.ts swift package --package-path apple/macos-helper clean && pnpm build:macos-helper",
110+
"test:macos-helper": "node --experimental-strip-types scripts/swift-toolchain-tmpdir.ts swift test --package-path apple/macos-helper",
111+
"check:macos-helper": "pnpm build:macos-helper && pnpm test:macos-helper",
110112
"prepare:publish-assets": "node scripts/prepare-publish-assets.mjs",
111113
"build:package": "pnpm build && pnpm build:xcuitest:ios && pnpm build:xcuitest:macos && pnpm build:xcuitest:tvos && pnpm build:xcuitest:visionos && pnpm build:macos-helper:clean && pnpm prepare:publish-assets",
112114
"package:npm": "pnpm build:package && pnpm check:package",

‎scripts/check-affected/checks.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export const CHECK_CATALOG: readonly CheckSpec[] = [
7878
// helpers packaged into `android/*/dist` (what the replay host verifies), where the
7979
// build script writes only the snapshot helper into `.tmp/`.
8080
gate('android-helpers', 'Android helper builds (snapshot + IME)', 'build:android', false),
81-
gate('macos-helper', 'macOS helper build', 'build:macos-helper', false),
81+
gate('macos-helper', 'macOS helper build and tests', 'check:macos-helper', false),
8282
gate('web-smoke', 'Live web platform smoke', 'test:smoke:web', false),
8383
// Needs full history and tags, so it runs in the shared fetch-depth: 0 job
8484
// rather than inside the shallow-clone-safe unit lane.

0 commit comments

Comments
 (0)